feat(collections/unstable): support Iterable argument in takeLastWhile()
#6090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6090 +/- ##
==========================================
- Coverage 96.75% 96.75% -0.01%
==========================================
Files 509 510 +1
Lines 39175 39199 +24
Branches 5795 5802 +7
==========================================
+ Hits 37905 37926 +21
- Misses 1228 1231 +3
Partials 42 42 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a backwards compatible unstable version of
takeLastWhile()that accepts an iterable instead of arrays.The array version is significantly more performant, so adding a special case for when the iterable is an array.
#5470