-
Notifications
You must be signed in to change notification settings - Fork 657
feat(collections): stabilize Iterable
input for chunk
, dropLastWhile
, dropWhile
, intersect
, sample
, slidingWindows
, sortBy
, takeLastWhile
, takeWhile
, and withoutAll
#6644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kt3k
merged 14 commits into
denoland:main
from
kt3k:stabilize-collections-iterable-input
May 9, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Liam Tait <[email protected]> Co-authored-by: David Luis <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6644 +/- ##
==========================================
- Coverage 94.75% 94.74% -0.01%
==========================================
Files 584 574 -10
Lines 46563 46412 -151
Branches 6541 6521 -20
==========================================
- Hits 44120 43974 -146
+ Misses 2400 2395 -5
Partials 43 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
98621ea
to
a63eb00
Compare
bartlomieju
approved these changes
May 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support of
Iterable
inputs for the APIs:These have been first implemented as unstable APIs, and this PR stabilizes them.
related:
#6095
#6090
#6088
#6076
#6036
#6035
#6031
#5925
#5919
#5911