Add build-deps image #1346
Merged
Add build-deps image #1346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthalman
reviewed
Feb 6, 2025
src/azurelinux/manifest.json
Outdated
Comment on lines
949
to
953
| "dockerfile": "src/azurelinux/3.0/build-deps", | ||
| "os": "linux", | ||
| "osVersion": "azurelinux3.0", | ||
| "tags": { | ||
| "azurelinux-3.0-build-deps-amd64": {} |
There was a problem hiding this comment.
I'm not sure the deps suffix really adds anything. Every image in this repo is kind of a deps image already.
There was a problem hiding this comment.
That's true. I was motivate to ensure people realized there was no SDK inside. However, I have low care factor on that.
Co-authored-by: Matt Thalman <[email protected]>
|
Can you help me with codeowners @mthalman? I'm not sure what to do for that. |
mthalman
reviewed
Feb 7, 2025
lbussell
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: dotnet/aspnetcore#60208
The intent is to provide an image that you can install an arbitrary SDK on, likely from ci.dot.net, and that has Node.js installed. This should be usable by most C# only repos.
I'm wondering if we should adopt a new naming scheme:
build-depstest-deps(replacing Helix)Runtime has their own crazy naming scheme. No need to reason about that.