Skip to content

Add build-deps image #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 7, 2025
Merged

Add build-deps image #1346

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
06c6587
Add build-deps image
richlander Feb 6, 2025
ac37096
Update src/azurelinux/manifest.json
richlander Feb 6, 2025
11ff159
Change name
richlander Feb 6, 2025
e0ef84e
Update codeowners
mthalman Feb 7, 2025
c0be5ff
Fix formatting
mthalman Feb 7, 2025
6288bbf
Update runtime-deps to 10.0
richlander Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/azurelinux/3.0/build-deps/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# This should be switched to 10.0 as soon as P1 ships for long-term-ness
FROM mcr.microsoft.com/dotnet/runtime-deps:8.0-azurelinux3.0

RUN tdnf install nodejs -y \
&& tdnf clean all

19 changes: 15 additions & 4 deletions src/azurelinux/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,7 +590,6 @@
}
]
},

{
"platforms": [
{
Expand Down Expand Up @@ -784,7 +783,7 @@
]
},
{
"platforms": [
"platforms": [
{
"dockerfile": "src/azurelinux/3.0/net10.0/android/amd64",
"os": "linux",
Expand Down Expand Up @@ -916,7 +915,6 @@
}
]
},

{
"platforms": [
{
Expand All @@ -943,8 +941,21 @@
"variant": "v8"
}
]
},
{
"platforms": [
{
"architecture": "amd64",
"dockerfile": "src/azurelinux/3.0/build-deps",
"os": "linux",
"osVersion": "azurelinux3.0",
"tags": {
"azurelinux-3.0-build-deps-amd64": {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the deps suffix really adds anything. Every image in this repo is kind of a deps image already.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true. I was motivate to ensure people realized there was no SDK inside. However, I have low care factor on that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it.

}
}
]
}
]
}
]
}
}
Loading