-
Notifications
You must be signed in to change notification settings - Fork 108
Add support for the .slack_api connector #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The readme for this generated client links through to the 8.7 version of the API spec. Can we update the reference there as well?
generated/connectors/bundled.yaml
Outdated
@@ -2590,6 +2664,7 @@ components: | |||
- .servicenow-sir | |||
- .server-log | |||
- .slack | |||
- .slack-api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like this in the version of this spec in the Kibana repo is it in the process of getting added there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be missed in that location in the OpenAPI spec, I'm reaching out to them to eventually find out what's up. I have confirmed manually that it exists in the response payload I get from Kibana.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ramework * origin/main: Fix mapping of webhook connectors that is stored in tfstate (elastic#433) Bump version for v0.8.0 Fix Kibana SLO panic `histogram_custom_indicator` (elastic#430) Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.26.1 to 2.29.0 (elastic#422) Bump github.com/hashicorp/terraform-plugin-docs in /tools (elastic#384) Bump github.com/golangci/golangci-lint from 1.54.1 to 1.54.2 in /tools (elastic#409) Bump actions/checkout from 3 to 4 (elastic#421) fix: update component documentation (elastic#420) Add support for the .slack_api connector (elastic#419)
No description provided.