Skip to content

fix: update component documentation #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

stefanfreitag
Copy link
Contributor

The template block expects an "aliases" block. However, this block is actually supposed to be named "alias".

Fixes #411

@cla-checker-service
Copy link

cla-checker-service bot commented Sep 10, 2023

💚 CLA has been signed

@stefanfreitag
Copy link
Contributor Author

Agreement has been signed.

Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this!

@tobio
Copy link
Member

tobio commented Sep 11, 2023

@stefanfreitag it looks like the commit in this PR was made under [email protected], not the [email protected] address that you signed the CLA with. Are you able to either rewrite the commit with the udo.edu address or re-sign the CLA with the rwe.com address?

The template block expects an "aliases" block. However, this block is actually supposed to be named "alias".
@stefanfreitag
Copy link
Contributor Author

@tobio Thanks for the feedback :) The authorship has been updated to [email protected]

@tobio tobio merged commit 3fa15e3 into elastic:main Sep 11, 2023
tobio added a commit to wandergeek/terraform-provider-elasticstack that referenced this pull request Oct 1, 2023
…ramework

* origin/main:
  Fix mapping of webhook connectors that is stored in tfstate (elastic#433)
  Bump version for v0.8.0
  Fix Kibana SLO panic `histogram_custom_indicator` (elastic#430)
  Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.26.1 to 2.29.0 (elastic#422)
  Bump github.com/hashicorp/terraform-plugin-docs in /tools (elastic#384)
  Bump github.com/golangci/golangci-lint from 1.54.1 to 1.54.2 in /tools (elastic#409)
  Bump actions/checkout from 3 to 4 (elastic#421)
  fix: update component documentation (elastic#420)
  Add support for the .slack_api connector (elastic#419)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Docs schema issue for elasticstack_elasticsearch_component_template
2 participants