-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Upgrade glimmer-vm #20842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade glimmer-vm #20842
Conversation
… anymore (once built)
…ed to go bundle / rollup types in Glimmer
This reverts commit b44b166.
…not needed, and is not public API -- it's compiled away during glimmer-vm publish
console.error(chalk.red(err.toString())); | ||
console.error(chalk.red(`Error!`)); | ||
|
||
if ('passed' in err) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change will print out:
{ passed: 40140, failed: 4, total: 40144, runtime: 47482 }
where as before it would print out [object Object]
Is our "rolling window" for TS support documented anywhere better than the 'Stability' heading here? https://blog.emberjs.com/stable-typescript-types-in-ember-5-1/ cc @emberjs/typescript-core |
That doesn't say what our rolling window of support is -- afaict the only place it is somewhat documented is in the CI config. |
It might be this:
So if we have 2+ LTS' with 5.0, we're good with that being our minimum, I think? |
I understand what the rolling support window concept is -- I am looking for somewhere we have documented which literal versions are supported by which versions of Ember that could be linked to in the release blog post. How can users easily tell which versions of Ember support which TS versions? |
I haven't seen that information exist anywhere. Do we have similar information for node support? should it live in the same place? |
Node support is here https://github.com/ember-cli/ember-cli/blob/master/docs/node-support.md |
Indeed this is the case. |
Replaces: #20801
Warning
This requires we drop TS < 5, because we need
verbatimModuleSyntax
. TS v5 came out in March of 2023, so folks have had plenty of time to move to a newer version (and this is even beyond the window of our Major release cadence, and I believe dropping this is fine, even though, we now require consumers useverbatimModuleSyntax
.Most of what's in these VM changes is prep for bigger bugfixes and improvements (especially to debug tooling / inspector stuff).
The timing of this PR is early, as we don't want a big VM upgrade all at once.
Every change has gone through performance testing, and found either no regression, or slight improvement.
Changelog:
Updates:
notes:
long ago, I made https://github.com/NullVoxPopuli/tsc-lite because
tsc
does not the wrong thing by hiding your most important errors at the top of the buffer (and sometimes you have enough errors that it surpasses your max-buffer, so you can't scroll to the most important error). tsc-lite shows only the first few chunks of the tsc output, so you can focus on what to fix first, in the proper order.This has come in handy here, as we broke the types in glimmer-vm (they need to be rolled up).