-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Upgrade glimmer-vm #20842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Upgrade glimmer-vm #20842
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
a3c588a
Upgrade the deps
NullVoxPopuli 9f70ea3
moduleResolution: node (10) is wrong, use bundler
NullVoxPopuli d0ab525
Update deps
NullVoxPopuli 9250dc2
Copy unwrapTemplate from glimmer-vm, as glimmer-vm doesn't include it…
NullVoxPopuli 8e000f3
Fix the owner type
NullVoxPopuli 423a04f
Update the debugKey type usage
NullVoxPopuli 0b42359
Update usages of CurriedType.Component to 0 as CurriedComponent
NullVoxPopuli 5593eec
Fix unwrapTemplate in curly.ts
NullVoxPopuli 17e374a
Fix type errors that aren't @glimmer/component related
NullVoxPopuli ebadd26
Update @glimmer/compiler
NullVoxPopuli 4015dd1
Remove skipLibCheck now that most of the migration is done. Now we ne…
NullVoxPopuli 479f57b
Upgrade deps
NullVoxPopuli 93b4286
Reverse exports?
NullVoxPopuli 763b51c
Upgrade Glimmer
NullVoxPopuli db5c75a
Closer?
NullVoxPopuli d2ed925
Build fixed?
NullVoxPopuli c495bd1
ugh, cjs
NullVoxPopuli 1500885
Tell import/no-unresolved to ignore @glimmer
NullVoxPopuli a9081ef
Disable import resolve entirely
NullVoxPopuli 9d69734
Significantly reduce type erros by upgrading the @tsconfig/ember package
NullVoxPopuli e9addd8
Fix type tests
NullVoxPopuli c4f99ae
Drop TS 4.9
NullVoxPopuli 94ae527
Fix test summary output
NullVoxPopuli 08b1d59
Upgrade deps again
NullVoxPopuli 7c9de30
error is specific enough?
NullVoxPopuli b44b166
Well, that's goofy
NullVoxPopuli 13ffeae
Revert "Well, that's goofy"
NullVoxPopuli 64fc979
@glimmer/debug was accidentally introduced in 5.9 or 5.11, but it is …
NullVoxPopuli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
packages/@ember/-internals/glimmer/lib/component-managers/unwrap-template.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import type { Template, TemplateOk } from '@glimmer/interfaces'; | ||
|
||
/** | ||
* @deprecated | ||
*/ | ||
export function unwrapTemplate(template: Template): TemplateOk { | ||
if (template.result === 'error') { | ||
throw new Error( | ||
`Compile Error: ${template.problem} @ ${template.span.start}..${template.span.end}` | ||
); | ||
} | ||
|
||
return template; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change will print out:
where as before it would print out
[object Object]