Skip to content

fix(tests): EIP-7702 verification/merge issue #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2025
Merged

fix(tests): EIP-7702 verification/merge issue #1358

merged 1 commit into from
Mar 27, 2025

Conversation

marioevz
Copy link
Member

🗒️ Description

Fixes a broken test for EIP-7702 introduced in #1288

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added type:bug Something isn't working scope:tests Scope: Changes EL client test cases in `./tests` labels Mar 26, 2025
@marioevz marioevz requested a review from winsvega March 26, 2025 22:31
@marioevz marioevz mentioned this pull request Mar 26, 2025
Merged
8 tasks
@winsvega
Copy link
Contributor

Ah was it referencing invalid nonse by default?

spencer-tb
spencer-tb approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spencer-tb spencer-tb merged commit b7c956b into main Mar 27, 2025
21 checks passed
@spencer-tb spencer-tb deleted the fix-eip-7702-test branch March 27, 2025 12:07
felix314159 pushed a commit to felix314159/execution-spec-tests that referenced this pull request May 16, 2025
@marioevz @felix314159
fix(tests): EIP-7702 verification/merge issue (ethereum#1358)
895319d
sonhv0212 pushed a commit to ronin-chain/execution-spec-tests that referenced this pull request May 19, 2025
@marioevz @sonhv0212
fix(tests): EIP-7702 verification/merge issue (ethereum#1358)
8076459
sonhv0212 pushed a commit to ronin-chain/execution-spec-tests that referenced this pull request May 20, 2025
@marioevz @sonhv0212
fix(tests): EIP-7702 verification/merge issue (ethereum#1358)
391a3c4
sonhv0212 added a commit to ronin-chain/execution-spec-tests that referenced this pull request May 21, 2025
@sonhv0212 @spencer-tb
@gumb0 @chfast @marioevz @winsvega @raxhvl @reedsa @fselmo @danceratopz @pdobacz
new(tests): sync prague tests (#32)
12850ce 
* feat(tests): EIP-2537: add bls12 audit test cases (ethereum#1275)

* fix(test): remove test violating EIP-7523 (ethereum#1257)

* fix(test): remove test violating EIP-7523

* Simplify the test by removing parameterization

* chore(tests): update bls12 test vectors (ethereum#1289)

* new(tests): add state test with empty 7702 authorization list (ethereum#1224)

* new(tests): add state test with empty 7702 authorization list

* fix(clis): Add exception to EELS

---------

Co-authored-by: Mario Vega <[email protected]>

* new(tests): EIP-7702: Sender not EOA test

* Add self-sponsored variant

* apply comments

* fix(test): improve EIP-7702 test for type 4 transaction with empty to (ethereum#1337)

* fix(tests): EIP-7702 verification/merge issue (ethereum#1358)

* new(tests): EIP-7702: More RLP tests (ethereum#1347)

* refactor(types): remove nonce-as-list from auth list

* new(tests): EIP-7702: Tx serialization tests

* refactor(tests): Use RLP encoding changes

* Change log

* new(tests): EIP-7702: more rlp tests

* 🧹 chore(EIP-7623): Remove duplicate fixture (ethereum#1381)

Co-authored-by: raxhvl <[email protected]>

* feat(tests): Additional EIP-2935 coverage (ethereum#1379)

Update CHANGELOG.md

* new(tests): EIP-7702: Delegation Designation as Initcode, max-fee-per-gas tests (ethereum#1372)

* new(tests): EIP-7702: Delegation designation as initcode

* new(tests): EIP-7702: Invalid max_fee_per_gas/max_priority_fee_per_gas

* docs: changelog

* refactor(tests): Combine similar cases into one

Co-Authored-By: spencer <[email protected]>

---------

Co-authored-by: spencer <[email protected]>

* fix(execute,tests): EIP-7702: send tx of eoa after setcode tx is mined (ethereum#1411)

* fix(tests): EIP-7702: send transaction of an EOA after setcode tx is mined

* refactor(execute): send batch of txs by block

* fix(tests): Parametrize instead of change

* refactor(execution): Change error check to per-block basis

---------

Co-authored-by: Mario Vega <[email protected]>

* feat(tests): update 7702 precompile test cases (ethereum#1431)

- Add a test case that calls the delegated precompile acct directly from
  the same transaction as the auth. Supply enough gas only to cover the
  intrinsic cost of the call, with no extra gas for any precompile
  code execution.

- Update the test case for all call opcodes to use all of the call opcodes.

* feat(tests): eip7623 - parametrize `test_transaction_validity_type_*` with a tx to an eoa (ethereum#1422)

* feat(tests): EIP-2537: extra BLS12-381 coverage (ethereum#1350)

* feat(tests): bls point generator and extra coverage.

* chore(tests): remove bls msm duplicates.

* chore: fix tox issues.

* feat(tests): Add more msm invalid tests

---------

Co-authored-by: Mario Vega <[email protected]>

* new(tests): EIP-7702 - ensure DELEGATECALLing a 7702 target works (ethereum#1485)

Co-authored-by: Mario Vega <[email protected]>

* feat(tests): add bls map to curve on identity cases (ethereum#1505)

* fix(tests): EIP-7702: use penultimate block number instead of fixing block 0 (ethereum#1390)

* fix(tests): EIP-7702: use penultimate block number instead of fixing block 0

* fix(tests): EIP-7702: use contract code to get blocknumber instead of rpc

* Update uv.lock

* Update uv.lock

* Update uv.lock

* Update uv.lock

* Update pyproject.toml

* refactor(base_types,types,tests): Create RLP Serialization Classes (ethereum#1359)

* fix(types): tests: Add serialization unit tests

* fix(types): tests: Fix unit tests

* feat(base_types): Implement serialization RLP types

* feat(base_types,types,fixtures): Apply serialization RLP types

* fix(types): Auth tuple defaults

* fix(fixtures,rpc,specs,types,tests): Transaction.rlp is a function

* fix(base_types,types,rpc): fixes

* refactor(base_types,types): Network wrapped transaction

* fix(tests): Network wrapped transactions

* fix(types): Fix NetworkWrappedTransaction rlp prefix

* docs: Changelog

* Apply suggestions from code review

Co-authored-by: spencer <[email protected]>

* Add network wrapper explanation

* fix: tox

* Update docs/CHANGELOG.md

Co-authored-by: spencer <[email protected]>

* Add comment

---------

Co-Authored-By: spencer <[email protected]>

* fix(tests): EIP-2537: mark slow

* fix(tests): EIP-7623: remove blob in blob tx

* fix(dependency): update prague execution specs

* new(dependency): add joblib

---------

Co-authored-by: spencer <[email protected]>
Co-authored-by: Andrei Maiboroda <[email protected]>
Co-authored-by: Paweł Bylica <[email protected]>
Co-authored-by: Mario Vega <[email protected]>
Co-authored-by: Dimitry Kh <[email protected]>
Co-authored-by: raxhvl <[email protected]>
Co-authored-by: raxhvl <[email protected]>
Co-authored-by: Stuart Reed <[email protected]>
Co-authored-by: felipe <[email protected]>
Co-authored-by: danceratopz <[email protected]>
Co-authored-by: pdobacz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winsvega winsvega winsvega approved these changes

@spencer-tb spencer-tb spencer-tb approved these changes

Assignees
No one assigned
Labels
scope:tests Scope: Changes EL client test cases in `./tests` type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marioevz @winsvega @spencer-tb