Skip to content

Support AAD in MSA #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2019
Merged

Support AAD in MSA #32

merged 1 commit into from
Apr 18, 2019

Conversation

jeschu1
Copy link
Contributor

@jeschu1 jeschu1 commented Apr 18, 2019

  • use common endpoint for MSA accounts

resolves #17

@jeschu1 jeschu1 requested a review from mjcheetham April 18, 2019 16:20
@mjcheetham mjcheetham self-assigned this Apr 18, 2019
@mjcheetham mjcheetham added host:azure-repos Specific to the Azure Repos (Azure DevOps, VSTS) host provider bug A bug in Git Credential Manager labels Apr 18, 2019
mjcheetham
mjcheetham approved these changes Apr 18, 2019
View reviewed changes
Copy link
Collaborator

@mjcheetham mjcheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Just one nit.

@jeschu1
Support AAD in MSA
2ed3790 
- use common endpoint for MSA accounts
@jeschu1 jeschu1 merged commit 48553d0 into git-ecosystem:master Apr 18, 2019
mjcheetham added a commit that referenced this pull request May 8, 2019
@mjcheetham
Merge pull request #39 from microsoft/master
4bcb796 
Merge master to release including #29, #30, #32, #33, #34, #35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcheetham mjcheetham mjcheetham approved these changes

Assignees

@mjcheetham mjcheetham

Labels
bug A bug in Git Credential Manager host:azure-repos Specific to the Azure Repos (Azure DevOps, VSTS) host provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Microsoft Authentication component should use the common endpoint for MSA auth
2 participants
@jeschu1 @mjcheetham