Skip to content

Produce and collect symbols on build #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2019
Merged

Produce and collect symbols on build #33

merged 1 commit into from
May 1, 2019

Conversation

mjcheetham
Copy link
Collaborator

Ensure we are generating symbols (dSYM) for native macOS binaries and collect both managed and native symbols and publish them as a build artefact.

Fixes #28

@mjcheetham mjcheetham added platform:osx Specific to the macOS platform engineering Refactoring or build changes labels Apr 23, 2019
@mjcheetham mjcheetham requested a review from jrbriggs April 23, 2019 18:26
Copy link
Contributor

@jrbriggs jrbriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mjcheetham mjcheetham merged commit aea0ab9 into git-ecosystem:master May 1, 2019
@mjcheetham mjcheetham deleted the dsym-archive branch May 1, 2019 15:24
mjcheetham added a commit that referenced this pull request May 8, 2019
Merge master to release including #29, #30, #32, #33, #34, #35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Refactoring or build changes platform:osx Specific to the macOS platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mac binary symbols should be collected and archived/published
2 participants