Infinite scroll #9638
Infinite scroll #9638
Conversation
harshit-dxt
requested review from
chibie,
frankchen07,
gdixon,
PixelantDesign and
thelostone-mc
as code owners
|
Added a delay of 2 seconds to show how the icon looked. Would love some feedback on this. |
| @@ -346,7 +346,7 @@ | |||
| </div> | |||
| </div> | |||
|
|
|||
| <div class="col-12 mb-3 mx-auto col-md-6 text-center" v-else> | |||
| <div class="col-12 mb-3 mx-auto col-md-6 text-center" v-else-if="!lock && grants && grants.length == 0"> | |||
There was a problem hiding this comment.
what does the !lock do here ?
There was a problem hiding this comment.
!lock ensures that as long as the fetchGrants() is working it should not display the obiwan-bot saying that there exists no other grant.
|
@PixelantDesign + @frankchen07 could you have a look at this |
|
Gentle Reminder @thelostone-mc @PixelantDesign. |
|
Gentle Reminder @thelostone-mc @PixelantDesign @gdixon @chibie @frankchen07 |
thelostone-mc
force-pushed
the
master
branch
from
e276966 to
df02065
Compare
| @@ -359,6 +359,10 @@ <h1 class="font-title-lg font-weight-semibold mt-4 mb-2">{% trans "This is not t | |||
| </button> | |||
| </div> | |||
| </div> | |||
|
|
|||
| <div class="col-12 mb-3 mx-auto col-md-6 text-center text-center" v-show="lock"> | |||
| <img class="w-100" src="https://s.gitcoin.co/static/v2/images/loading_v2.f27849139c28.gif"> | |||
There was a problem hiding this comment.
Absolute URLs should be hardcoded. Please us "{% static ... %}"
There was a problem hiding this comment.
Changed this to "{% static %}" format.
gdixon
force-pushed
the
master
branch
3 times, most recently
from
a15aeb3 to
c0d45b0
Compare
Description
I just displayed a loading icon whenever there is loading state.
Refers/Fixes
Fixes: Now shows loading for new grants.
#9616
Testing
I just added an icon to display whenever loading