Skip to content

Infinite scroll #9638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Infinite scroll #9638

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01c3bad
Added loading_gif whenever in loading state. Fixes Feat: add infinit…
harshit-dxt Oct 27, 2021
5f8814e
Infinite scrolling grants loading state displayed
harshit-dxt Oct 28, 2021
eb1ba16
Update the hardcoded url to django static asset url form
harshit-dxt Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/grants/templates/grants/explorer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@
</div>
</div>

<div class="col-12 mb-3 mx-auto col-md-6 text-center" v-else>
<div class="col-12 mb-3 mx-auto col-md-6 text-center" v-else-if="!lock && grants && grants.length == 0">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does the !lock do here ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!lock ensures that as long as the fetchGrants() is working it should not display the obiwan-bot saying that there exists no other grant.

<img class="obiwan my-4" src="{% static "v2/images/obiwan-bot.svg" %}">
<h1 class="font-title-lg font-weight-semibold mt-4 mb-2">{% trans "This is not the grant you’re looking for." %}</h1>
<p class="font-subheader text">
Expand All @@ -359,6 +359,10 @@ <h1 class="font-title-lg font-weight-semibold mt-4 mb-2">{% trans "This is not t
</button>
</div>
</div>

<div class="col-12 mb-3 mx-auto col-md-6 text-center text-center" v-show="lock">
<img class="w-100" src="{% static "v2/images/loading_v2.gif" %}">
</div>
</template>
</b-tab>
<b-tab ref="collections" id="collections" title-link-class="nav-line font-weight-bold">
Expand Down Expand Up @@ -688,6 +692,7 @@ <h1 class="font-title-lg font-weight-semibold mt-4 mb-2">{% trans "This is not t
</div>
</div>
</template>

</template>
</div>

Expand Down