Skip to content

Use JSON response for "user/logout" #25522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

wxiaoguang
Copy link
Contributor

The request sent to "user/logout" is from "link-action", it expects to get JSON response.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 26, 2023
@wxiaoguang wxiaoguang added this to the 1.21.0 milestone Jun 26, 2023
@wxiaoguang wxiaoguang added type/bug backport/v1.20 This PR should be backported to Gitea 1.20 labels Jun 26, 2023
@delvh
Copy link
Member

delvh commented Jun 26, 2023

Does this perhaps fix #25436?

@wxiaoguang
Copy link
Contributor Author

Nope, it's unrelated.

But after this PR, backend can have full control of the "redirect URL", so it's easy to change the "redirect behavior" to anything the users like in the future.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 26, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 26, 2023
@KN4CK3R KN4CK3R merged commit ddf96f6 into go-gitea:main Jun 26, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jun 26, 2023
The request sent to "user/logout" is from "link-action", it expects to
get JSON response.
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Jun 26, 2023
@wxiaoguang wxiaoguang deleted the fix-user-logout branch June 27, 2023 01:49
@wxiaoguang wxiaoguang removed backport/done All backports for this PR have been created backport/v1.20 This PR should be backported to Gitea 1.20 labels Jun 27, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants