Skip to content

Use JSON response for "user/logout" (#25522) #25530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

GiteaBot
Copy link
Collaborator

Backport #25522 by @wxiaoguang

The request sent to "user/logout" is from "link-action", it expects to get JSON response.

The request sent to "user/logout" is from "link-action", it expects to
get JSON response.
@GiteaBot GiteaBot added this to the 1.20.0 milestone Jun 26, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 26, 2023
@GiteaBot GiteaBot requested review from delvh and KN4CK3R June 26, 2023 21:14
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 26, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 26, 2023
@jolheiser jolheiser enabled auto-merge (squash) June 26, 2023 21:27
@jolheiser jolheiser added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 26, 2023
@silverwind
Copy link
Member

Lint does not like it. I think we may be missing another backport on the branch.

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jun 27, 2023

The JS part and Go part both changed in 1.21, so the backport should be done manually if necessary. While I think this bug is not that serious so no need to backport.

@wxiaoguang wxiaoguang closed this Jun 27, 2023
auto-merge was automatically disabled June 27, 2023 02:17

Pull request was closed

@GiteaBot GiteaBot removed this from the 1.20.0 milestone Jun 27, 2023
@techknowlogick techknowlogick deleted the backport-25522-v1.20 branch June 27, 2023 02:23
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 27, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants