Skip to content

Remove multiple GRPC_*_EXPERIMENTAL_* env variables #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove multiple GRPC_*_EXPERIMENTAL_* env variables #169

wants to merge 1 commit into from

Conversation

sergiitk
Copy link
Member

@sergiitk sergiitk commented Apr 9, 2025 •
edited
Loading

These variables were set to "true", now being removed:

  • GRPC_EXPERIMENTAL_ENABLE_OUTLIER_DETECTION
  • GRPC_EXPERIMENTAL_XDS_CUSTOM_LB_CONFIG
  • GRPC_EXPERIMENTAL_XDS_ENABLE_OVERRIDE_HOST
  • GRPC_XDS_EXPERIMENTAL_ENABLE_RETRY
  • GRPC_XDS_EXPERIMENTAL_NEW_SERVER_API
  • GRPC_XDS_EXPERIMENTAL_RBAC
  • GRPC_XDS_EXPERIMENTAL_SECURITY_SUPPORT
  • GRPC_XDS_EXPERIMENTAL_V3_SUPPORT

The following env variables are kept and are set to "true":

  • GRPC_EXPERIMENTAL_ENABLE_NEW_PICK_FIRST
  • GRPC_EXPERIMENTAL_XDS_DUALSTACK_ENDPOINTS
  • GRPC_XDS_EXPERIMENTAL_ENABLE_RING_HASH

@sergiitk
Remove multiple GRPC_*_EXPERIMENTAL_* env variables
d35bd57 
These variables were set to "true", now being removed:

- GRPC_EXPERIMENTAL_ENABLE_OUTLIER_DETECTION
- GRPC_EXPERIMENTAL_XDS_CUSTOM_LB_CONFIG
- GRPC_EXPERIMENTAL_XDS_ENABLE_OVERRIDE_HOST
- GRPC_XDS_EXPERIMENTAL_ENABLE_RETRY
- GRPC_XDS_EXPERIMENTAL_NEW_SERVER_API
- GRPC_XDS_EXPERIMENTAL_RBAC
- GRPC_XDS_EXPERIMENTAL_SECURITY_SUPPORT
- GRPC_XDS_EXPERIMENTAL_V3_SUPPORT
@sergiitk sergiitk requested a review from a team as a code owner April 9, 2025 22:36
@sergiitk
Copy link
Member Author

sergiitk commented Apr 9, 2025

It's difficult to track all of them, but here's a few relevant changes:

@sergiitk
Copy link
Member Author

sergiitk commented Apr 9, 2025

Oldest java:

Oldest cpp:

@sergiitk sergiitk mentioned this pull request Apr 9, 2025
Merged
ejona86
ejona86 approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect GRPC_XDS_EXPERIMENTAL_ENABLE_RING_HASH could also be removed, but I don't think this needs to be perfect (removing the ones you are is still a win).

@murgatroid99
Copy link
Member

You should leave GRPC_XDS_EXPERIMENTAL_RBAC. Node is going to need that soon.

@sergiitk
Copy link
Member Author

cc @kannanjgithub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejona86 ejona86 ejona86 approved these changes

@XuanWang-Amos XuanWang-Amos XuanWang-Amos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sergiitk @murgatroid99 @ejona86 @XuanWang-Amos