Avoid multiple default config names #7585
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix duplicating default config names.
Currently, when calling
push_to_hub(set_default=True
with 2 different config names, both are set as default.Moreover, this will generate an error next time we try to push another default config name, raised by
MetadataConfigs.get_default_config_name
:datasets/src/datasets/arrow_dataset.py
Line 5757 in da1db8a
datasets/src/datasets/utils/metadata.py
Lines 186 to 188 in da1db8a