Fix smolagents benchmark #1377
Merged
Fix smolagents benchmark #1377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymeric-roucher
commented
May 24, 2025
| " ds.push_to_hub(\n", | ||
| " push_to_hub_dataset, config_name=config, set_default=set_default, commit_message=f\"Upload {config} results\"\n", | ||
| " )\n", | ||
| " ds.push_to_hub(push_to_hub_dataset, config_name=config, commit_message=f\"Upload {config} results\")\n", |
There was a problem hiding this comment.
@albertvillanova removed the set_default argument, because for me it was trying to pop the default from a previous dataset, which didn't exist, thus raised an error. But there's probably a better way to fix this issue?
There was a problem hiding this comment.
I am trying to figure out what the error was, when it was generated, and how to fix it...
There was a problem hiding this comment.
I opened a PR in datasets:
There was a problem hiding this comment.
Until the fix is released, I would suggest not passing set_default, as you did.
Co-authored-by: Albert Villanova del Moral <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some bugs introduced by changing token usage reporting in #1337.
In particular, it makes sure to properly serialize model outputs before logging them while running the benchmark.