Hpu bucketing #489
Merged
Hpu bucketing #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kaixuanliu <[email protected]>
Signed-off-by: kaixuanliu <[email protected]>
Signed-off-by: kaixuanliu <[email protected]>
Signed-off-by: kaixuanliu <[email protected]>
regisss
reviewed
Mar 7, 2025
| @@ -13,6 +13,7 @@ | |||
| is_hpu = is_hpu() | |||
| use_ipex = use_ipex() | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
You mean no need for is_hpu and use_ipex? The reason we use global variables here is to avoid calling is_hpu() function and use_ipex() function multiple times, as it will cost a lot of time for these two functions.
There was a problem hiding this comment.
No no, I was talking about the blank line that was added. It's the only change to this file so I don't think we need it. I know it's not a big change, but let's try to keep PR as minimal as possible.
Signed-off-by: kaixuanliu <[email protected]>
Narsil
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.