-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove print statements from FBX plugin #1777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Change a print statement in FbxAnimCurveNode.java to a logger call
Thank you for proposing this change. The FBX loader contains 13 print statements directed to Does the issue relate to |
I spent some time resolving warnings logged by JME in my project, and noticed I kept getting this print statement. So this was the only one that affected me, but if you prefer, I could do the same to the rest of the occurrences. Just wanted to change this merely for the fact of cleaning up my console log. |
The rogue message isn't a warning. I suspect it's someone's old temporary debugging code. So, just to be sure I understand ... the only impact was unnecessary messages on the console, which might've made actual diagnostics easy to overlook? |
I know it's not a warning. In the process of resolving warnings, I spotted the output of this print statement in my console. And it doesn't help me to have it there (and frankly I'd like to have it gone). And by making it a So, yes, that is the the only impact—just me being picky on the cleanliness of my console :) |
Thank you for your patience. Now that I understand the issue/motivation, I'm OK with this PR as is. However, I notice that the straightforward conversion of |
Yes, I do agree. An alternative would be to define the string lazily. But I don't suspect these statements are getting enough attention to warrant implementing that. I'll comment them out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for your cooperation and thoroughness!
This changes a print statement in
FbxAnimCurveNode.java
to a logger call so it doesn't contaminate output.