Skip to content

Remove print statements from FBX plugin #1777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2022
Merged

Remove print statements from FBX plugin #1777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83fd63f
Change println to logger
wyskoj Feb 23, 2022
ba56747
Comment-out print statements in FbxLoader
wyskoj Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions jme3-plugins/src/fbx/java/com/jme3/scene/plugins/fbx/anim/FbxAnimCurveNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,9 @@ public Vector3f getVector3Value(long time) {
*/
public Quaternion getQuaternionValue(long time) {
Vector3f eulerAngles = getVector3Value(time);
System.out.println("\tT: " + time + ". Rotation: " +
eulerAngles.x + ", " +
eulerAngles.y + ", " + eulerAngles.z);
// System.out.println("\tT: " + time + ". Rotation: " +
// eulerAngles.x + ", " +
// eulerAngles.y + ", " + eulerAngles.z);
Quaternion q = new Quaternion();
q.fromAngles(eulerAngles.x * FastMath.DEG_TO_RAD,
eulerAngles.y * FastMath.DEG_TO_RAD,
Expand Down
4 changes: 2 additions & 2 deletions jme3-plugins/src/fbx/java/com/jme3/scene/plugins/fbx/anim/FbxToJmeTrack.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ private Track toJmeTrackInternal(int boneIndex, Transform inverseBindPose) {
if (time > duration) {
// Expand animation duration to fit the curve.
duration = time;
System.out.println("actual duration: " + duration);
// System.out.println("actual duration: " + duration);
}

times[i] = time;
Expand All @@ -153,7 +153,7 @@ private Track toJmeTrackInternal(int boneIndex, Transform inverseBindPose) {
rotations[i] = rotationCurve.getQuaternionValue(fbxTime);
if (i > 0) {
if (rotations[i - 1].dot(rotations[i]) < 0) {
System.out.println("rotation will go the long way, oh noes");
// System.out.println("rotation will go the long way, oh noes");
rotations[i - 1].negateLocal();
}
}
Expand Down
32 changes: 16 additions & 16 deletions jme3-plugins/src/fbx/java/com/jme3/scene/plugins/fbx/node/FbxNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,14 +171,14 @@ public void setWorldBindPose(Matrix4f worldBindPose) {
this.jmeWorldBindPose.setRotation(worldBindPose.toRotationQuat());
this.jmeWorldBindPose.setScale(worldBindPose.toScaleVector());

System.out.println("\tBind Pose for " + getName());
System.out.println(jmeWorldBindPose);
// System.out.println("\tBind Pose for " + getName());
// System.out.println(jmeWorldBindPose);

float[] angles = new float[3];
jmeWorldBindPose.getRotation().toAngles(angles);
System.out.println("Angles: " + angles[0] * FastMath.RAD_TO_DEG + ", " +
angles[1] * FastMath.RAD_TO_DEG + ", " +
angles[2] * FastMath.RAD_TO_DEG);
// System.out.println("Angles: " + angles[0] * FastMath.RAD_TO_DEG + ", " +
// angles[1] * FastMath.RAD_TO_DEG + ", " +
// angles[2] * FastMath.RAD_TO_DEG);
}

public void updateWorldTransforms(Transform jmeParentNodeTransform, Transform parentBindPose) {
Expand Down Expand Up @@ -208,15 +208,15 @@ public void updateWorldTransforms(Transform jmeParentNodeTransform, Transform pa
jmeLocalBindPose.combineWithParent(parentBindPose.invert());

// It's somewhat odd for the transforms to differ ...
System.out.println("Bind Pose for: " + getName());
if (!jmeLocalBindPose.equals(jmeLocalNodeTransform)) {
System.out.println("Local Bind: " + jmeLocalBindPose);
System.out.println("Local Trans: " + jmeLocalNodeTransform);
}
if (!jmeWorldBindPose.equals(jmeWorldNodeTransform)) {
System.out.println("World Bind: " + jmeWorldBindPose);
System.out.println("World Trans: " + jmeWorldNodeTransform);
}
// System.out.println("Bind Pose for: " + getName());
// if (!jmeLocalBindPose.equals(jmeLocalNodeTransform)) {
// System.out.println("Local Bind: " + jmeLocalBindPose);
// System.out.println("Local Trans: " + jmeLocalNodeTransform);
// }
// if (!jmeWorldBindPose.equals(jmeWorldNodeTransform)) {
// System.out.println("World Bind: " + jmeWorldBindPose);
// System.out.println("World Trans: " + jmeWorldNodeTransform);
// }
} else {
// World pose derived from local transforms
// (this is to be expected for FBX nodes)
Expand Down Expand Up @@ -480,7 +480,7 @@ public static void createSkeletons(FbxNode fbxNode) {
throw new UnsupportedOperationException();
}
fbxNode.skeleton = FbxLimbNode.createSkeleton(fbxNode);
System.out.println("created skeleton: " + fbxNode.skeleton);
// System.out.println("created skeleton: " + fbxNode.skeleton);
}
}

Expand All @@ -505,7 +505,7 @@ public static Spatial createScene(FbxNode fbxNode) {
FbxNode preferredParent = fbxChild.getPreferredParent();
Spatial jmeChild = fbxChild.getJmeObject();
if (preferredParent != null) {
System.out.println("Preferred parent for " + fbxChild + " is " + preferredParent);
// System.out.println("Preferred parent for " + fbxChild + " is " + preferredParent);

Node jmePreferredParent = (Node) preferredParent.getJmeObject();
relocateSpatial(jmeChild, fbxChild.jmeWorldNodeTransform,
Expand Down