-
Notifications
You must be signed in to change notification settings - Fork 47
Jruby 9k #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mkristian I hadn't noticed this PR. I've been working on this same thing at #119. Everything is green now on java 11, and jruby 9.2. I dropped support for stuff older than that, because IMO opinion this repo seems virtually unmaintained so we should aim just for the latest stable versions. Still need to fix some stuff that I skipped, but it's looking good I believe. |
@deivid-rodriguez yes, I just saw you PR never mind. in the end I wanted to drop a few things. maybe I just pick your branch and drop what I wanted to drop ? I mean make small PRs against your branch . . . |
The branch is not really ready. I think maybe better if you first drop what you want to drop, then I can rebase this to fix the rest of the stuff. |
ok - I make a next I wanted to replace all these |
Sure. Why not master though, if I may ask? |
habit - but I can do it on master. np |
@deivid-rodriguez any ways merge this branch to master now |
Awesome thanks! I'll rebase #119 on top of your changes and get it ready 👍. |
I'm not sure whether this is still relevant. In #126 I have continued to migrate to latest JRuby plus latest mavengem, as part of an overall push to update the JRuby/Maven stack (but also to address the v1/dependencies shutdown). |
The update to JRuby 9k happened long ago, and in #126 I updated JRuby to 9.4.3.0, but there are other parts here that could be re-applied in 3.0.1. |
Prep jruby-9k and reduce size of overall plugins