-
Notifications
You must be signed in to change notification settings - Fork 47
Migrate to JRuby group ID and get things passing #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mkristian This is the other part of the work to update mavengems. Mostly this updates JRuby and a few plugins to latest, moves everything under the org.jruby.maven group ID, and uses latest mavengems instead of gem proxies for all dependencies. |
This makes the following changes: * de.saumya.mojo maven group ID changes to org.jruby.maven in all published artifacts * mavengem is used for all gem retrieval instead of the defunct TorqueBox proxy server * mavengem and related dependencies are now sourced from the org.jruby.maven 2.0.0 versions * minor additional changes to get tests passing with the new artifacts This passes all unit and integration tests and deploys successfully as org.jruby.maven:jruby-maven-plugins:3.0.0-SNAPSHOT and should now be immune to the v1/dependencies rubygems.org API shutdown (jruby/mavengem#8).
2f23398
to
8dd4f72
Compare
Various releases of Java have ignored user.dir updates, which causes this form of PWD-passing to fail on those versions. Just use JRuby's -C flag, which bypasses user.dir. See https://bugs.openjdk.org/browse/JDK-8291662
headius
added a commit
to headius/jruby
that referenced
this pull request
Aug 3, 2023
This update is necessary to get JRuby 9.4.3.0 running throughout the JRuby/Maven stack, which is necessary to move to the new mavengems. See jruby/jruby-maven-plugins#126 See jruby/mavengems#9
headius
added a commit
to headius/jruby
that referenced
this pull request
Aug 3, 2023
This update is necessary to get JRuby 9.4.3.0 running throughout the JRuby/Maven stack, which is necessary to move to the new mavengems. See jruby/jruby-maven-plugins#126 See jruby/mavengem#9
headius
added a commit
to headius/jruby
that referenced
this pull request
Aug 3, 2023
This update is necessary to get JRuby 9.4.3.0 running throughout the JRuby/Maven stack, which is necessary to move to the new mavengems. See jruby/jruby-maven-plugins#126 See jruby/mavengem#9
headius
added a commit
to headius/jruby
that referenced
this pull request
Aug 3, 2023
This update is necessary to get JRuby 9.4.3.0 running throughout the JRuby/Maven stack, which is necessary to move to the new mavengems. See jruby/jruby-maven-plugins#126 See jruby/mavengem#9 There is also a change to replace the use of `jruby_plugin` in test/pom.rb with a normal `plugin` DSL call, due to the former hardcoding an old package for the jruby-maven-plugins. See jruby/maven-tools#37
headius
added a commit
to headius/jruby
that referenced
this pull request
Aug 3, 2023
This update is necessary to get JRuby 9.4.3.0 running throughout the JRuby/Maven stack, which is necessary to move to the new mavengems. See jruby/jruby-maven-plugins#126 See jruby/mavengem#9 There are also changes to replace the use of `jruby_plugin` in several poms with a normal `plugin` DSL call, due to the former hardcoding an old package for the jruby-maven-plugins. See jruby/maven-tools#37
This was referenced Aug 3, 2023
Closed
headius
added a commit
to headius/polyglot-maven
that referenced
this pull request
Aug 3, 2023
This is part of work to update the entire JRuby/Maven stack, in order to update the version of JRuby used and to address API deprecations at rubygems.org. This PR updates JRuby to latest (9.4.3.0) and moves all plugins to their new org.jruby.maven group ID with latest versions. Fixes takari#37. We will need to coordinate getting this released along with the maven plugins in the very near term. Because of the rubygems.org API being shut down next week (the 8th), we are under the gun. See jruby/mavengem#9, jruby/jruby-maven-plugins#126, jruby/maven-tools#38 and jruby/jruby#7872.
headius
added a commit
to headius/polyglot-maven
that referenced
this pull request
Aug 3, 2023
This is part of work to update the entire JRuby/Maven stack, in order to update the version of JRuby used and to address API deprecations at rubygems.org. This PR updates JRuby to latest (9.4.3.0) and moves all plugins to their new org.jruby.maven group ID with latest versions. Part of the fix for jruby/maven-tools#37. We will need to coordinate getting this released along with the maven plugins in the very near term. Because of the rubygems.org API being shut down next week (the 8th), we are under the gun. See jruby/mavengem#9, jruby/jruby-maven-plugins#126, jruby/maven-tools#38 and jruby/jruby#7872.
headius
added a commit
to headius/polyglot-maven
that referenced
this pull request
Aug 4, 2023
This is part of work to update the entire JRuby/Maven stack, in order to update the version of JRuby used and to address API deprecations at rubygems.org. This PR updates JRuby to latest (9.4.3.0) and moves all plugins to their new org.jruby.maven group ID with latest versions. Part of the fix for jruby/maven-tools#37. We will need to coordinate getting this released along with the maven plugins in the very near term. Because of the rubygems.org API being shut down next week (the 8th), we are under the gun. See jruby/mavengem#9, jruby/jruby-maven-plugins#126, jruby/maven-tools#38 and jruby/jruby#7872.
headius
added a commit
to headius/polyglot-maven
that referenced
this pull request
Aug 4, 2023
This is part of work to update the entire JRuby/Maven stack, in order to update the version of JRuby used and to address API deprecations at rubygems.org. This PR updates JRuby to latest (9.4.3.0) and moves all plugins to their new org.jruby.maven group ID with latest versions. The maven-tools gem is updated to 1.2. Part of the fix for jruby/maven-tools#37. We will need to coordinate getting this released along with the maven plugins in the very near term. Because of the rubygems.org API being shut down next week (the 8th), we are under the gun. See jruby/mavengem#9, jruby/jruby-maven-plugins#126, jruby/maven-tools#38 and jruby/jruby#7872.
headius
added a commit
to headius/jruby
that referenced
this pull request
Aug 4, 2023
This update is necessary to get JRuby 9.4.3.0 running throughout the JRuby/Maven stack, which is necessary to move to the new mavengems. See jruby/jruby-maven-plugins#126 See jruby/mavengem#9 There are also changes to replace the use of `jruby_plugin` in several poms with a normal `plugin` DSL call, due to the former hardcoding an old package for the jruby-maven-plugins. See jruby/maven-tools#37
headius
added a commit
to headius/jruby
that referenced
this pull request
Aug 9, 2023
This update is necessary to get JRuby 9.4.3.0 running throughout the JRuby/Maven stack, which is necessary to move to the new mavengems. See jruby/jruby-maven-plugins#126 See jruby/mavengem#9 There are also changes to replace the use of `jruby_plugin` in several poms with a normal `plugin` DSL call, due to the former hardcoding an old package for the jruby-maven-plugins. See jruby/maven-tools#37
cstamas
added a commit
to takari/polyglot-maven
that referenced
this pull request
Aug 25, 2023
This is part of work to update the entire JRuby/Maven stack, in order to update the version of JRuby used and to address API deprecations at rubygems.org. This PR updates JRuby to latest (9.4.3.0) and moves all plugins to their new org.jruby.maven group ID with latest versions. Part of the fix for jruby/maven-tools#37. (incorrectly tagged as #37 here before) We will need to coordinate getting this released along with the maven plugins in the very near term. Because of the rubygems.org API being shut down next week (the 8th), we are under the gun. See jruby/mavengem#9, jruby/jruby-maven-plugins#126, jruby/maven-tools#38 and jruby/jruby#7872.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the following changes:
This passes all unit and integration tests and deploys successfully as org.jruby.maven:jruby-maven-plugins:3.0.0-SNAPSHOT and should now be immune to the v1/dependencies rubygems.org API shutdown (jruby/mavengem#8).