Allow chat handlers to be initialized in any order #1268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlqqq
added
enhancement
dlqqq
requested changes
Feb 27, 2025
|
@Darshan808 Thank you for working on this so quickly! The code looks perfect, aside from some minor feedback above. |
|
Thanks for the feedback |
|
Good work @Darshan808 |
dlqqq
approved these changes
Mar 3, 2025
There was a problem hiding this comment.
@Darshan808 Awesome, thank you! 🎉
I'll merge this to help fix Jupyter AI on main. Can you help backport this to 2.x?
|
@meeseeksdev please backport to 2.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyter-ai
that referenced
this pull request
Mar 3, 2025
|
Oh wow, it was backported without conflicts. Didn't expect that. We can take this from here and reach out if we need anything. |
srdas
pushed a commit
that referenced
this pull request
Mar 3, 2025
…#1269) Co-authored-by: Darshan Poudel <[email protected]>
5 tasks
Darshan808
added a commit
to Darshan808/jupyter-ai
that referenced
this pull request
Mar 4, 2025
* lazy-initialize-retriever * add-retriever-property
dlqqq
pushed a commit
that referenced
this pull request
Mar 10, 2025
* make native chat handlers customizable * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove-ci-error * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add-disabled-check-and-sort-entrypoints * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Refactor Chat Handlers to Simplify Initialization (#1257) * simplify-entrypoints-loading * fix-lint * fix-tests * add-retriever-typing * remove-retriever-from-base * fix-circular-import(ydoc-import) * fix-tests * fix-type-check-failure * refactor-retriever-init * Allow chat handlers to be initialized in any order (#1268) * lazy-initialize-retriever * add-retriever-property * rebase-into-main * update-docs * update-documentation --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
srdas
pushed a commit
to srdas/jupyter-ai
that referenced
this pull request
Mar 11, 2025
* make native chat handlers customizable * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove-ci-error * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add-disabled-check-and-sort-entrypoints * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Refactor Chat Handlers to Simplify Initialization (jupyterlab#1257) * simplify-entrypoints-loading * fix-lint * fix-tests * add-retriever-typing * remove-retriever-from-base * fix-circular-import(ydoc-import) * fix-tests * fix-type-check-failure * refactor-retriever-init * Allow chat handlers to be initialized in any order (jupyterlab#1268) * lazy-initialize-retriever * add-retriever-property * rebase-into-main * update-docs * update-documentation --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
srdas
added a commit
that referenced
this pull request
Mar 20, 2025
…enAI provider (#1264) * Simplifying the OpenAI provider to use multiple model providers * Update openrouter.md * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * openai general interface added * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * embedding * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updated settings to take OpenAI generic embedding models * added openai generic embeddings screenshot * Fixed Issue 1261 * bump version floor on jupyter server * linter * adding embedding model fields * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update test_config_manager * Update pyproject.toml * Update pyproject.toml * Update pyproject.toml * pyproject.toml fixes * pyproject.toml updates * Update pyproject.toml * Update pyproject.toml * Make Native Chat Handlers Overridable via Entry Points (#1249) * make native chat handlers customizable * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove-ci-error * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add-disabled-check-and-sort-entrypoints * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Refactor Chat Handlers to Simplify Initialization (#1257) * simplify-entrypoints-loading * fix-lint * fix-tests * add-retriever-typing * remove-retriever-from-base * fix-circular-import(ydoc-import) * fix-tests * fix-type-check-failure * refactor-retriever-init * Allow chat handlers to be initialized in any order (#1268) * lazy-initialize-retriever * add-retriever-property * rebase-into-main * update-docs * update-documentation --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * pyproject toml files * pyproject toml updates * update snapshot * writing config file correctly * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * tsx lint * Update use-server-info.ts * Update pyproject.toml * adds embedding_models attribute * Fixed display of Base url for embeddings and completions * removed embedding_models * Added help fields * Update chat-settings.tsx * minor reversions moved to new issue --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Darshan Poudel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1267
This PR resolves issue seen in #1257 by ensuring that chat handlers can be initialized in any order.
Specifically, it modifies
AskChatHandler._retrieverto be a lazily initialized property, eliminating the need forLearnChatHandlerto be defined and stored before initializingAskChatHandler. This improves maintainability and flexibility in handler initialization.