Skip to content

Allow chat handlers to be initialized in any order #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2025
Merged

Allow chat handlers to be initialized in any order #1268

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2db9ee
lazy-initialize-retriever
Darshan808 Feb 27, 2025
5a6d628
add-retriever-property
Darshan808 Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions packages/jupyter-ai/jupyter_ai/chat_handlers/ask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,20 @@ def __init__(self, *args, **kwargs):

self.parser.prog = "/ask"
self.parser.add_argument("query", nargs=argparse.REMAINDER)
learn_chat_handler = self.chat_handlers.get("/learn")
if not isinstance(learn_chat_handler, LearnChatHandler):
raise CustomLearnException()
# NOTE: devs should use self.retriever property to access the retriever
self._retriever = None # Will be set when accessed

self._retriever = Retriever(learn_chat_handler=learn_chat_handler)
@property
def retriever(self):
"""Lazy-loads and caches the retriever instance"""
if self._retriever is None:
learn_chat_handler = self.chat_handlers.get("/learn")
if not isinstance(learn_chat_handler, LearnChatHandler):
raise CustomLearnException()

self._retriever = Retriever(learn_chat_handler=learn_chat_handler)

return self._retriever # Return cached instance

def create_llm_chain(
self, provider: Type[BaseProvider], provider_params: Dict[str, str]
Expand All @@ -69,7 +78,7 @@ def create_llm_chain(

self.llm_chain = ConversationalRetrievalChain.from_llm(
self.llm,
self._retriever,
self.retriever,
memory=memory,
condense_question_prompt=CONDENSE_PROMPT,
verbose=False,
Expand Down
Loading