-
-
Notifications
You must be signed in to change notification settings - Fork 408
Add default_completions_model
trait
#1303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
default_completions_model
trait
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srdas Thank you for building this! Changes look good. Verified with local testing. Feel free to merge & backport!
@meeseeksdev please backport to 2.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
* Updating inline completions config fields from prespecified custom config file * Update extension.py (cherry picked from commit a82eecc)
…t) (#1306) * Update learn.py * Add `default_completions_model` trait (#1303) * Updating inline completions config fields from prespecified custom config file * Update extension.py (cherry picked from commit a82eecc) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update extension.py --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
model_parameters
trait to embedding & completion models #1298.Users can specify a pre-specified configuration file titled jupyter_jupyter_ai_config.json in any of the paths shown when running jupyter --paths (see the documentation here). A sample of this file is shown below:
Issue: Currently, the
default_completions_model
is not being updated inconfig.json
as this is not handled. This PR enables completions models config in a manner consistent with that done for language models and embedding models.For reviewers
To test this:
completions_model_provider_id
and thecompletions_fields
with the required content from the pre-specified config file.jupyter_jupyter_ai_config.json