Skip to content

Backport PR #1303 on branch 2.x (Add default_completions_model trait) #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 3, 2025

Conversation

srdas
Copy link
Collaborator

@srdas srdas commented Apr 3, 2025

Refers to PR #1303

Users can specify a pre-specified configuration file titled jupyter_jupyter_ai_config.json in any of the paths shown when running jupyter --paths (see the documentation here).

Fixes merge conflicts in PR 1303.

srdas and others added 4 commits March 21, 2025 14:53
* Updating inline completions config fields from prespecified custom config file

* Update extension.py

(cherry picked from commit a82eecc)
@srdas srdas added the bug Bugs reported by users label Apr 3, 2025
@srdas srdas requested a review from dlqqq April 3, 2025 19:58
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srdas Thanks for working on this! Just a couple of minor comments.

@srdas srdas requested a review from dlqqq April 3, 2025 22:00
@dlqqq dlqqq changed the title Backport PR #1303 on branch 2.x (Add default_completions_model trait) Backport PR #1303 on branch 2.x (Add default_completions_model trait) Apr 3, 2025
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srdas Thank you!

@srdas srdas merged commit 5709d6e into jupyterlab:2.x Apr 3, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs reported by users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants