Skip to content

Fix: cgroup_skb pogs should respect enable_monitoring flag #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025

Conversation

hzxuzhonghu
Copy link
Member

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@hzxuzhonghu
Copy link
Member Author

Fix #1310

@yp969803
Copy link
Contributor

yp969803 commented Apr 18, 2025

Also you can Log the error, stating storage not found, i havnt done this because previously i was not checking is_monitoring_enable, hence can result to unecessary logs

@yp969803
Copy link
Contributor

yp969803 commented Apr 18, 2025

if (!is_monitoring_enable()) {
        return;

this check can be done at

static inline void observe_on_data(struct bpf_sock *sk)
function, resulting in non repeating code

@yp969803
Copy link
Contributor

Btw, thanku for taking this issue made my work easy :)

@hzxuzhonghu
Copy link
Member Author

@yp969803 addressed all your comments

Copy link

codecov bot commented Apr 21, 2025

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 45.43%. Comparing base (b1ea0b3) to head (df56fd8).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
pkg/bpf/bpf.go 16.66% 3 Missing and 2 partials ⚠️
pkg/controller/controller.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
pkg/controller/controller.go 0.00% <0.00%> (ø)
pkg/bpf/bpf.go 41.44% <16.66%> (-0.34%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f216fd3...df56fd8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yp969803
Copy link
Contributor

/lgtm

@kmesh-bot
Copy link
Collaborator

@yp969803: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hzxuzhonghu
Copy link
Member Author

@hzxuzhonghu
Copy link
Member Author

/assign @LiZhenCheng9527

@LiZhenCheng9527
Copy link
Contributor

/lgtm
/approve

@kmesh-bot kmesh-bot added the lgtm label Apr 22, 2025
@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiZhenCheng9527

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 7bfd83d into kmesh-net:main Apr 22, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants