-
Notifications
You must be signed in to change notification settings - Fork 109
Fix: cgroup_skb pogs should respect enable_monitoring flag #1313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix #1310 |
kmesh/bpf/kmesh/probes/probe.h Line 99 in ae81023
Also you can Log the error, stating storage not found, i havnt done this because previously i was not checking is_monitoring_enable, hence can result to unecessary logs |
this check can be done at kmesh/bpf/kmesh/probes/probe.h Line 87 in ae81023
|
Btw, thanku for taking this issue made my work easy :) |
Signed-off-by: Zhonghu Xu <[email protected]>
Signed-off-by: Zhonghu Xu <[email protected]>
f79f8d4
to
df56fd8
Compare
@yp969803 addressed all your comments |
Codecov ReportAttention: Patch coverage is
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
/lgtm |
@yp969803: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @LiZhenCheng9527 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LiZhenCheng9527 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: