-
Notifications
You must be signed in to change notification settings - Fork 109
Fix: unexpected log when pod is shutting down #1383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…torage is not created, so remove the error logging Signed-off-by: Zhonghu Xu <[email protected]>
Signed-off-by: Zhonghu Xu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes unnecessary logging during pod shutdown and adjusts the behavior of BPF probe functions to suppress expected errors.
- In the controller, a pod deletion check is added in handlePodUpdate and log level in enableKmeshManage is changed to Debug.
- In the probe code, the construct_orig_dst_info API is updated to require an external storage parameter and the error logging in observe_on_close/observe_on_data is suppressed.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
pkg/controller/manage/manage_controller.go | Added pod deletion check and changed log level to Debug to avoid noisy logs. |
bpf/kmesh/probes/tcp_probe.h | Modified the construct_orig_dst_info signature to require a storage parameter. |
bpf/kmesh/probes/probe.h | Suppressed error logging in sock storage retrieval scenarios with clarifying comments. |
Comments suppressed due to low confidence (1)
bpf/kmesh/probes/tcp_probe.h:112
- The construct_orig_dst_info function signature now requires an external storage parameter. Ensure that all callers pass a valid non-null storage object to prevent potential runtime issues.
static inline void construct_orig_dst_info(struct bpf_sock *sk, struct sock_storage_data *storage, struct tcp_probe_info *info)
Codecov ReportAttention: Patch coverage is
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LiZhenCheng9527 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created: #1385 |
What type of PR is this?
What this PR does / why we need it:
For #1381
eliminate these logs during pod shutdown
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: