Skip to content

[release-1.1] Fix: unexpected log when pod is shutting down #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kmesh-bot
Copy link
Collaborator

This is an automated cherry-pick of #1383


…torage is not created, so remove the error logging

Signed-off-by: Zhonghu Xu <[email protected]>
Copy link

codecov bot commented May 9, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 46.25%. Comparing base (263f2cd) to head (4b86298).
Report is 4 commits behind head on release-1.1.

Files with missing lines Patch % Lines
pkg/controller/manage/manage_controller.go 20.00% 6 Missing and 2 partials ⚠️
Files with missing lines Coverage Δ
pkg/controller/manage/manage_controller.go 52.81% <20.00%> (-1.04%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62cb154...4b86298. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LiZhenCheng9527
Copy link
Contributor

/lgtm
/approve

@kmesh-bot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiZhenCheng9527

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 65667b8 into kmesh-net:release-1.1 May 9, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants