Create KubernetesClientConfiguration from pre-loaded K8SConfiguration #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/S
tg123
reviewed
Oct 22, 2018
| /// <param name="k8sConfig">A <see cref="K8SConfiguration"/>, for example loaded from <see cref="LoadKubeConfigAsync(string, bool)" /></param> | ||
| /// <param name="currentContext">Override the current context in config, set null if do not want to override</param> | ||
| /// <param name="masterUrl">Override the Kubernetes API server endpoint, set null if do not want to override</param> | ||
| public static KubernetesClientConfiguration BuildConfig(K8SConfiguration k8SConfig, string currentContext = null, string masterUrl = null) |
There was a problem hiding this comment.
just naming to make this easier to understand.
Suggested change
| public static KubernetesClientConfiguration BuildConfig(K8SConfiguration k8SConfig, string currentContext = null, string masterUrl = null) | |
| public static KubernetesClientConfiguration BuildConfigFromCurrent(K8SConfiguration k8SConfig, string currentContext = null, string masterUrl = null) |
There was a problem hiding this comment.
Good plan. I'm going to propose BuildConfigFromConfigObject to align with ...FromConfigFile and because 'current' doesn't quite describe it. But agree it needs additional qualification - thanks!
tg123
approved these changes
Oct 25, 2018
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, itowlson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreates #170 by @markrendle (with Mark's consent, as he does not have bandwidth to update it). From the original description:
"Hi. I'm working on a GUI application that loads the K8SConfiguration, then creates KubernetesClientConfiguration instances based on user selection. Since I've already got the config data loaded, it makes sense to be able to create the client config directly from it, so I've added a new static method BuildConfig that takes the K8SConfiguration instance as a parameter. I guess I could have made the existing GetKubernetesClientConfiguration method public, but I don't like messing with existing API.
Oh, I also fixed up a doc comment that was wrong :)"
And I tweaked a couple more doc comments too.