Create KubernetesClientConfiguration from pre-loaded K8SConfiguration #170
Conversation
|
I've signed the CNCF CLA now. |
|
@markrendle I think you must have changed line endings or spacing or something? The PR shows a bunch of diffs that don't actually look like diffs and it makes it pretty hard to see the actual changes. Can you see what happened and clean up the diff for easier reviewing? Many thanks! |
|
(also Travis is failing...) |
|
@brendandburns Oops, sorry about that. Will fix this afternoon. |
|
hey @markrendle is this PR still active? Thanks! |
|
I recently cloned this repo and noticed some files are mixing EOL styles within the same file. It would help if the repo took control and added a |
|
@gitfool historical reason before |
|
Right. Either way any previously existing files should be cleaned up to meet the newly enforced style. Otherwise, in the EOL case at least, Visual Studio will keep popping up warning dialogs:
(One could uncheck "always show this dialog", but I prefer to be warned so I can fix any issues.) |
|
@gitfool, I'm happy to have someone send a cleanup PR converting to \n line endings... Thanks! |
itowlson
added
the
cncf-cla: yes
|
@markrendle Sent a PR to your PR to rebase it onto latest master (with all the line ending shenanigans hopefully sorted out). RendleLabs#1 If you don't have time/energy to look at this, let me know if it would be okay for me to pick up your original change and recreate it (with appropriate credit of course). |
|
@itowlson I'd be really happy if you could recreate this, I don't have the bandwidth at the moment. |
|
Superseded by #213 which rebases this onto latest master. |
Hi. I'm working on a GUI application that loads the
K8SConfiguration, then createsKubernetesClientConfigurationinstances based on user selection. Since I've already got the config data loaded, it makes sense to be able to create the client config directly from it, so I've added a new static methodBuildConfigthat takes theK8SConfigurationinstance as a parameter. I guess I could have made the existingGetKubernetesClientConfigurationmethod public, but I don't like messing with existing API.Oh, I also fixed up a doc comment that was wrong :)