Rebase onto latest master #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace it with the new (officially-supported) ClientWebSocket SSL functionality in .NET Core 2.1. kubernetes-client#130
… behavior (kubernetes-client#174) * Fix issue with X509VerificationFlags.AllowUnknownCertificateAuthority behavior * Add CertificateValidationTests
* fix test case fail on windows * fix cert not working on windows * changed to RuntimeInformation to see if osx * change to a more common way to deal with line ending (due to git autocrlf)
…ernetes-client#184) * Watcher: Add onClosed event and callback * Update the code generators to accept the onClose callback * Re-generate API * Update unit tests * Fix unit test * Watcher fixes/improvements: - Run Task.Yield at the beginning to make sure we're running async - Set Watching = false before invoking OnClosed, to make sure the callers see a consistent state.
* generate v1.11 -rc3 * add generated watcher * regenrate with 1.11.0
* add patch example * fix typo
…-client#183) (kubernetes-client#190) * Update WatcherDelegatingHandler to stop eating first line (kubernetes-client#183) * Override Read methods in PeekableStreamReader to avoid unpredicted behaviour (kubernetes-client#183) Override Read methods in PeekableStreamReader to avoid unpredicted behaviour (kubernetes-client#183)
* Move Fractions library inside project * Add README and license
* align files to .editorconfig * fix space cause build failed
* generate for 1.12 * run watch generator * bump version
itowlson
force-pushed
the
pr/markrendle/170
branch
from
90c5926 to
807f7a0
Compare
itowlson
force-pushed
the
pr/markrendle/170
branch
from
807f7a0 to
043a342
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Mark, keen to get your kubernetes-client/csharp
buildconfigbranch merged, so here's a PR to your PR. This is rebased onto latest master, which includes a fix for the line endings stuff (as well as a pile of other stuff, which is why this PR looks so large). I think if you take all these changes then we should get a cleaner diff against current master (and if not, it at least gives me a starting point for trying to bash the line endings into shape), and the only functional change against current master should be the one from your initial PR.If you don't have bandwidth to look at this, do you mind if I take your changes and create a new PR off latest upstream master? I will of course credit them to you. Thanks!