feat(ovh): major rewriting of the provider

[rbeuque74]

Hello 👋

Description

Major rewriting of the OVHcloud provider:

• better DNS record update process: previously, updated record were performing a delete+create operation, now it perform an update operation
• dry-run has been implemented
• better cache invalidation on errors: we now perform a more optimized cache invalidation, without refreshing the DNS zone to avoid inconsistent zone push
• relative CNAME handling: previous implementation handled only absolut CNAME target, we now allow to use relative one (optional to avoid breaking changes for exisitng users)
• maintainers update: as part of the OVHcloud API core team, I will maintain the provider part :)

Checklist

• Unit tests updated
• End user documentation updated

[k8s-ci-robot]

Hi @rbeuque74. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mloiseleur]

Hello @rbeuque74,

We have started the process to move providers out of tree, with a webhook system. See #4347 and webhook provider doc

Since you seem to work for OVH, wdyt about creating a webhook provider for OVH ?

As you can see, there are already many webhook providers.

[rbeuque74]

Hello @mloiseleur

That seem a great idea that we can put in our backlog.
What is the suggested workflow for existing users that will have to migrate ?

Also, since #4932, changes regarding cache invalidation cause users that have multiple instances of external-dns to harmer the OVHcloud DNS API.
I would like to have this merge prior the webhook migration.

Thanks
Romain

[ivankatliarchuk]

The pull request seems like doing more then just cache invalidation. Am I understand the changes correctly?

[rbeuque74]

Yes indeed, I took the opportunity to refactor a bit how things were working in the ovh provider engine.
UpdateOld and UpdateNew changes were always triggering deletion of the records and re-creation of the records associated to the endpoint, while sometime it just needed to add a new record, or just update an existing one.
This will prevent the item deleted error while applying the changes.

Also, we improved the cache regarding already fetched records between Records and ApplyChanges to prevent unnecessary fetching.

[ivankatliarchuk]

I'll try to review code as soon as I could. Could you also provide a set of manual test steps using manifests and kubectl commands? This will help in understanding and verifying the implementation for areas touched? example #5085 (comment)

[ivankatliarchuk]

/ok-to-test

[rbeuque74]

/retest

[ivankatliarchuk]

/label tide/merge-method-squash

[rbeuque74]

I'll try to review code as soon as I could. Could you also provide a set of manual test steps using manifests and kubectl commands? This will help in understanding and verifying the implementation for areas touched? example #5085 (comment)

Do you also need OVHcloud DNS API credentials, or you already have an account ?
If you don't, I can provide some, but that would require a GPG key to send them over to you.

[ivankatliarchuk]

Would be nice to have a testing account. Ping me in kubernetes slack if you could. Or you could run smoke tests and share steps and results here.

[ivankatliarchuk]

Is it ok not to force-push? Difficutl to understand what was reviewed. Last commit could be a squash

[ivankatliarchuk]

could you also execute please make cover-html and cover modified lines with unit test? For lines related to logs output, we have a test helper

external-dns/internal/testutils/log.go

Line 36 in 4b2fd49

func LogsToBuffer(level log.Level, t *testing.T) *bytes.Buffer {

would be quite nice to cover where possible.

[rbeuque74]

Hello @mloiseleur ,
thanks for review. Comments have been adressed :)

Romain

[mloiseleur]

/ok-to-test

[rbeuque74]

Hey,

Comments have been addressed, and commits have been rebased to make sure tests can run.

[mloiseleur]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk, mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mloiseleur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment