Handle request value with zero in CountIn

[qti-haeyoon]

What type of PR is this?

/kind bug

What this PR does / why we need it:

When resource request value is zero, it should be handled appropriately to count correctly.

Which issue(s) this PR fixes:

Fixes #4970

Special notes for your reviewer:

Does this PR introduce a user-facing change?

TAS: Fix bug where scheduling panics when the workload using TopologyAwareScheduling has container request value specified as zero.

[k8s-ci-robot]

Welcome @qti-haeyoon!

It looks like this is your first PR to kubernetes-sigs/kueue 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kueue has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @qti-haeyoon. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	429589a
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67fdfb9ead53600008cb28ca

[mimowo]

/ok-to-test
@qti-haeyoon thank you for the contribution. This looks correct, but since there is a user facing impact I would prefer to also add a higher-level test. I'm thinking about TestScheduleForTAS. WDYT?

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: qti-haeyoon (429589a, 86ee786)

[qti-haeyoon]

/retest

[qti-haeyoon]

/ok-to-test @qti-haeyoon thank you for the contribution. This looks correct, but since there is a user facing impact I would prefer to also add a higher-level test. I'm thinking about TestScheduleForTAS. WDYT?

Thanks for the review @mimowo . I added a simple test case in 429589a. Please let me know if there are more cases to add.

[mimowo]

Please also extend the release note to mention TAS. My proposal would be

TAS: Fix bug where scheduling panics when the workload using TopologyAwareScheduling has container request value specified as zero.

[qti-haeyoon]

Please also extend the release note to mention TAS. My proposal would be

TAS: Fix bug where scheduling panics when the workload using TopologyAwareScheduling has container request value specified as zero.

Sounds good, updated as suggested.

[mimowo]

Thank you!
/lgtm
/approve
/cherry-pick release-0.11 release-0.10

Out of curiosity, do you have a legitimate use case for using requests equal 0? In any case Kueue should handle it gracefully and not panic.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, qti-haeyoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mimowo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 34cda3ea476c90c083d957ada3b5704d11d36f94

[qti-haeyoon]

Out of curiosity, do you have a legitimate use case for using requests equal 0? In any case Kueue should handle it gracefully and not panic.

One use case I can describe would be when we have a template that generate a workload based on request which can be parameterized and sometimes we want to use value 0. Maybe not very realistic for CPU or memory, but for other kind of resources such as GPU.

[mimowo]

Makes perfect sense. Thank you for describing the use case and the contribution.

[mimowo]

/cherry-pick release-0.11 release-0.10

[k8s-infra-cherrypick-robot]

@mimowo: new pull request created: #4973

In response to this:

/cherry-pick release-0.11 release-0.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.