Skip to content

[release-0.11] Handle request value with zero in CountIn #4973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2025
Merged

[release-0.11] Handle request value with zero in CountIn #4973

merged 2 commits into from
Apr 15, 2025

Conversation

k8s-infra-cherrypick-robot
Copy link
Contributor

This is an automated cherry-pick of #4971

/assign mimowo

TAS: Fix bug where scheduling panics when the workload using TopologyAwareScheduling has container request value specified as zero.

/cherrypick release-0.10

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 15, 2025
Merged
@k8s-ci-robot k8s-ci-robot added this to the v0.11 milestone Apr 15, 2025
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 15, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 15, 2025
@netlify Netlify
Copy link

netlify bot commented Apr 15, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 07c1533
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67fe0355ad53600008ccb789
😎 Deploy Preview https://deploy-preview-4973--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mimowo
Copy link
Contributor

mimowo commented Apr 15, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e78602833006ae4e19f0cfbbb6eea5feff591c02

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2025
@k8s-ci-robot k8s-ci-robot merged commit 5c95e28 into kubernetes-sigs:release-0.11 Apr 15, 2025
19 checks passed
@k8s-infra-cherrypick-robot
Copy link
Contributor Author

@k8s-infra-cherrypick-robot: new pull request created: #4974

In response to this:

This is an automated cherry-pick of #4971

/assign mimowo

TAS: Fix bug where scheduling panics when the workload using TopologyAwareScheduling has container request value specified as zero.

/cherrypick release-0.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 15, 2025
Closed
@qti-haeyoon qti-haeyoon mentioned this pull request Apr 15, 2025
Merged
k8s-ci-robot pushed a commit that referenced this pull request Apr 15, 2025
@qti-haeyoon
Automated cherry pick of #4973: Handle request value with zero in Cou…
08f703e 
…ntIn (#4976)

* Update count to maxInt32 when request value is zero

* Add test case in TestScheduleForTAS

* Add topology label to podset
@mimowo
Copy link
Contributor

mimowo commented Apr 16, 2025

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PBundyra PBundyra Awaiting requested review from PBundyra

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

Assignees

@mimowo mimowo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.11
Development

Successfully merging this pull request may close these issues.
4 participants
@k8s-infra-cherrypick-robot @mimowo @k8s-ci-robot @qti-haeyoon