fix: retry artifacts download #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note-none
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @nestoracunablanco - I've reviewed your changes - here's some feedback:
- Introduce a delay (e.g., exponential backoff) between retry attempts to avoid hammering the download endpoint.
- Use a warning log or include the current attempt number in the retry log to improve observability when downloads fail repeatedly.
- Extract the hardcoded retry count into a constant or configuration to make retry behavior easier to adjust.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
0xFelix
reviewed
May 26, 2025
nestoracunablanco
force-pushed
the
fix/retryDownload
branch
from
88a0aa6 to
2aef28b
Compare
0xFelix
reviewed
May 26, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
jcanocan
reviewed
May 26, 2025
cmd/medius/images/push.go
Outdated
| func (b *buildAndPublish) getArtifactReader(artifactInfo *api.ArtifactDetails) (http.ReadCloserWithChecksum, error) { | ||
| var artifactReader http.ReadCloserWithChecksum | ||
| var err error | ||
| for range 3 { |
There was a problem hiding this comment.
Could you please use a const here?
Signed-off-by: Nestor Acuna Blanco <[email protected]>
nestoracunablanco
force-pushed
the
fix/retryDownload
branch
from
2aef28b to
099d640
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: