feat: require nested virtualization detection in s390x workloads #4175

nestoracunablanco · 2025-05-20T09:34:34Z

This commit also removes the usage of the SLIM tag, as the slim
variant is automatically used for s390x.

Release note:

NONE

This commit also removes the usage of the SLIM tag, as the slim variant is automatically used for s390x. Signed-off-by: Nestor Acuna Blanco <[email protected]>

nestoracunablanco · 2025-05-20T09:35:16Z

/rehearse

kubevirt-bot · 2025-05-20T09:35:39Z

⚠️ @nestoracunablanco you need to be an approver for all the files to run rehearsal.

@lyarwood can help run the rehearsal.

If that doesn't work, ping someone from this list:

enp0s3
phoracek
tiraboschi
aglitke
brianmcarey
davidvossel
dhiller
rmohr
vladikr
xpivarc

sourcery-ai

Hey @nestoracunablanco - I've reviewed your changes and they look great!

Here's what I looked at during the review

🟢 General issues: all looks good
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

lyarwood

/rehearse
/approve

lyarwood · 2025-05-20T09:55:05Z

/rehearse

kubevirt-bot · 2025-05-20T09:55:19Z

Rehearsal jobs created for this PR:

rehearsal-pull-containerdisks-pipeline-fedora-s390x
rehearsal-pull-containerdisks-pipeline-centos-stream-9-s390x
rehearsal-pull-containerdisks-pipeline-ubuntu-s390x
rehearsal-pull-containerdisks-pipeline-centosstream-s390x

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

lyarwood · 2025-05-20T10:17:39Z

/test pull-containerdisks-pipeline-fedora-s390x

kubevirt-bot · 2025-05-20T10:17:42Z

@lyarwood: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build-autoowners-image

/test build-bootstrap-image

/test build-fedora-coreos-kubevirt-image

/test build-kubekins-e2e-image

/test build-kubevirt-infra-bootstrap-image

/test build-kubevirt-kubevirt.github.io-image

/test build-kubevirt-user-guide-image

/test build-pr-creator-image

/test build-prow-deploy-image

/test build-release-tool-image

/test build-shared-images-controller-image

/test build-test-label-analyzer-image

/test build-test-subset-image

/test build-vm-image-builder-image

/test check-prow-config

/test pull-kubevirt-org-github-config-updater

/test pull-project-infra-check-testgrid-config

/test pull-project-infra-ci-search-deploy-test

/test pull-project-infra-coverage

/test pull-project-infra-grafana-deploy-test

/test pull-project-infra-job-config-validator

/test pull-project-infra-lint

/test pull-project-infra-prow-deploy-test

/test pull-project-infra-test-external-plugins

/test pull-project-infra-test-github-ci-services

/test pull-project-infra-test-releng

/test pull-project-infra-test-robots

/test pull-prow-kubevirt-labels-update-precheck

/test pull-prow-nmstate-labels-update-precheck

Use /test all to run the following jobs that were automatically triggered:

check-prow-config

pull-project-infra-check-testgrid-config

pull-project-infra-lint

pull-project-infra-prow-deploy-test

In response to this:

/test pull-containerdisks-pipeline-fedora-s390x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lyarwood · 2025-05-20T10:18:09Z

/rehearse rehearsal-pull-containerdisks-pipeline-fedora-s390x

kubevirt-bot · 2025-05-20T10:18:41Z

Rehearsal jobs created for this PR:

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

nestoracunablanco · 2025-05-20T11:22:22Z

/rehearse rehearsal-pull-containerdisks-pipeline-fedora-s390x

kubevirt-bot · 2025-05-20T11:22:34Z

⚠️ @nestoracunablanco you need to be an approver for all the files to run rehearsal.

@lyarwood can help run the rehearsal.

If that doesn't work, ping someone from this list:

aglitke
davidvossel
dhiller
enp0s3
phoracek
tiraboschi
vladikr
brianmcarey
rmohr
xpivarc

lyarwood · 2025-05-20T11:46:44Z

/rehearse all

kubevirt-bot · 2025-05-20T11:46:53Z

Rehearsal jobs created for this PR:

rehearsal-pull-containerdisks-pipeline-fedora-s390x
rehearsal-pull-containerdisks-pipeline-ubuntu-s390x
rehearsal-pull-containerdisks-pipeline-centos-stream-9-s390x
rehearsal-pull-containerdisks-pipeline-centosstream-s390x

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

nestoracunablanco · 2025-05-22T07:19:20Z

/retest

lyarwood · 2025-05-22T07:26:58Z

/rehearse all

kubevirt-bot · 2025-05-22T07:27:21Z

Rehearsal jobs created for this PR:

rehearsal-pull-containerdisks-pipeline-centos-stream-9-s390x
rehearsal-pull-containerdisks-pipeline-ubuntu-s390x
rehearsal-pull-containerdisks-pipeline-centosstream-s390x
rehearsal-pull-containerdisks-pipeline-fedora-s390x

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

lyarwood · 2025-05-22T08:46:02Z

/approve cancel
/hold

As discussed there are issues with some mirrors supplying the s390x images.

We should file a ticket with the infra team of Fedora asking for these to be addressed. In the meantime we can also retry our requests here to workaround this for now. Can you wire something up in this PR?

https://github.com/kubevirt/containerdisks/blob/cda78a67ccc5ad09a5ead9ce7c1bf1758910b89a/cmd/medius/images/push.go#L189-L193

nestoracunablanco · 2025-05-22T09:03:37Z

Issue Opened: https://pagure.io/fedora-infrastructure/issue/12570

I'll follow up with you later regarding the retry logic.

Thanks for taking a look! 👍

nestoracunablanco · 2025-05-27T12:16:27Z

Hi @lyarwood @ksimon1, the PR with the retry logic in containerdisks has been merged. Since I do not have enough permissions, could you please rehearse the jobs again?

ksimon1 · 2025-06-02T08:10:29Z

/retest

lyarwood · 2025-06-02T08:10:41Z

/rehearse all

kubevirt-bot · 2025-06-02T08:10:52Z

Rehearsal jobs created for this PR:

rehearsal-pull-containerdisks-pipeline-centosstream-s390x
rehearsal-pull-containerdisks-pipeline-ubuntu-s390x
rehearsal-pull-containerdisks-pipeline-fedora-s390x
rehearsal-pull-containerdisks-pipeline-centos-stream-9-s390x

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

nestoracunablanco · 2025-06-02T08:43:50Z

The error persists on Fedora. In the meantime, I received feedback on the issue I opened. According to the response, the incorrect link should be removed within the next few hours.

nestoracunablanco · 2025-06-03T08:38:56Z

Hi @ksimon1 and @lyarwood, based on the output of the following command:
curl 'https://mirrors.fedoraproject.org/metalink?path=pub/fedora-secondary/releases/41/Cloud/s390x/images/Fedora-Cloud-Base-Generic-41-1.4.s390x.qcow2'
it appears that the URL should no longer redirect to the hostiserver mirror.
Could you please rehearse again? Thanks :)

ksimon1 · 2025-06-03T09:28:47Z

/rehearse all

kubevirt-bot · 2025-06-03T09:28:57Z

⚠️ @ksimon1 you need to be an approver for all the files to run rehearsal.

@lyarwood can help run the rehearsal.

If that doesn't work, ping someone from this list:

vladikr
xpivarc
aglitke
brianmcarey
davidvossel
phoracek
dhiller
enp0s3
rmohr
tiraboschi

lyarwood · 2025-06-03T09:30:57Z

/rehearse all

kubevirt-bot · 2025-06-03T09:31:07Z

Rehearsal jobs created for this PR:

rehearsal-pull-containerdisks-pipeline-centos-stream-9-s390x
rehearsal-pull-containerdisks-pipeline-ubuntu-s390x
rehearsal-pull-containerdisks-pipeline-fedora-s390x
rehearsal-pull-containerdisks-pipeline-centosstream-s390x

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

lyarwood · 2025-06-03T10:09:33Z

/approve
/lgtm

kubevirt-bot · 2025-06-03T10:09:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lyarwood

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~github/ci/prow-deploy/files/jobs/kubevirt/containerdisks/OWNERS~~ [lyarwood]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lyarwood · 2025-06-03T10:09:52Z

/hold cancel

kubevirt-bot · 2025-06-03T10:16:16Z

@nestoracunablanco: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

key containerdisks-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/containerdisks/containerdisks-presubmits.yaml

In response to this:

This commit also removes the usage of the SLIM tag, as the slim
variant is automatically used for s390x.

Release note:
NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

feat: require nested virtualization detection in s390x workloads

47f9b6b

This commit also removes the usage of the SLIM tag, as the slim variant is automatically used for s390x. Signed-off-by: Nestor Acuna Blanco <[email protected]>

kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label May 20, 2025

kubevirt-bot requested review from ksimon1 and lyarwood May 20, 2025 09:34

kubevirt-bot added the size/S label May 20, 2025

sourcery-ai bot reviewed May 20, 2025

View reviewed changes

lyarwood reviewed May 20, 2025

View reviewed changes

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2025

kubevirt-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 22, 2025

nestoracunablanco mentioned this pull request May 23, 2025

fix: retry artifacts download kubevirt/containerdisks#342

Merged

kubevirt-bot assigned lyarwood Jun 3, 2025

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2025

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2025

kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2025

kubevirt-bot merged commit 5389318 into kubevirt:main Jun 3, 2025
11 checks passed

nestoracunablanco deleted the feat/requireNestedVirtualization branch June 3, 2025 12:57

feat: require nested virtualization detection in s390x workloads #4175

feat: require nested virtualization detection in s390x workloads #4175

Uh oh!

Conversation

nestoracunablanco commented May 20, 2025

Uh oh!

nestoracunablanco commented May 20, 2025

Uh oh!

kubevirt-bot commented May 20, 2025

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

lyarwood left a comment

Choose a reason for hiding this comment

Uh oh!

lyarwood commented May 20, 2025

Uh oh!

kubevirt-bot commented May 20, 2025

Uh oh!

lyarwood commented May 20, 2025

Uh oh!

kubevirt-bot commented May 20, 2025

Uh oh!

lyarwood commented May 20, 2025

Uh oh!

kubevirt-bot commented May 20, 2025

Uh oh!

nestoracunablanco commented May 20, 2025

Uh oh!

kubevirt-bot commented May 20, 2025

Uh oh!

lyarwood commented May 20, 2025

Uh oh!

kubevirt-bot commented May 20, 2025

Uh oh!

nestoracunablanco commented May 22, 2025

Uh oh!

lyarwood commented May 22, 2025

Uh oh!

kubevirt-bot commented May 22, 2025

Uh oh!

lyarwood commented May 22, 2025

Uh oh!

nestoracunablanco commented May 22, 2025

Uh oh!

nestoracunablanco commented May 27, 2025

Uh oh!

ksimon1 commented Jun 2, 2025

Uh oh!

lyarwood commented Jun 2, 2025

Uh oh!

kubevirt-bot commented Jun 2, 2025

Uh oh!

nestoracunablanco commented Jun 2, 2025

Uh oh!

nestoracunablanco commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ksimon1 commented Jun 3, 2025

Uh oh!

kubevirt-bot commented Jun 3, 2025

Uh oh!

lyarwood commented Jun 3, 2025

Uh oh!

kubevirt-bot commented Jun 3, 2025

Uh oh!

lyarwood commented Jun 3, 2025

Uh oh!

kubevirt-bot commented Jun 3, 2025

Uh oh!

lyarwood commented Jun 3, 2025

Uh oh!

Uh oh!

kubevirt-bot commented Jun 3, 2025

Uh oh!

Uh oh!

nestoracunablanco commented Jun 3, 2025 •

edited

Loading