Add a stream that notifies us about received room key bundles #5288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poljar
requested review from
Hywan and
andybalaam
and removed request for
a team
poljar
force-pushed
the
poljar/shared-history/bundle-stream
branch
from
03e1e17 to
45d9183
Compare
Hywan
approved these changes
Jun 26, 2025
| use serde::{Deserialize, Serialize}; | ||
|
|
||
| use super::EventType; | ||
|
|
||
| // TODO: We need implement zeroize for this type. |
There was a problem hiding this comment.
Is it possible to open an issue to track this? It seems rather important isn't it?
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #5288 +/- ##
=======================================
Coverage 90.19% 90.19%
=======================================
Files 334 334
Lines 105155 105178 +23
Branches 105155 105178 +23
=======================================
+ Hits 94847 94870 +23
+ Misses 6245 6244 -1
- Partials 4063 4064 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4926.
This PR doesn't yet handle room key bundles received out of order. It is rather the building block which will notify us that we need to consider that a bundle might have arrived out of order.