fix(client-certificates): errors during http2 TLS handshake #32258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigation: Currently when a TLS handshake error happens on a http2 connection, the response gets corrupted. This is because:
secureConnect
eventerror
eventError: Received bad client magic byte string
andnet::ERR_HTTP2_PROTOCOL_ERROR
.This brought up that using the
session
event seems to be the right one for our use-case.Relates playwright-community/playwright-go#480
Example error: https://github.com/playwright-community/playwright-go/actions/runs/10465991368/job/28982096640?pr=480#step:6:166