Skip to content

chore: roll to Playwright v1.47.0 #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 6, 2024
Merged

chore: roll to Playwright v1.47.0 #480

merged 6 commits into from
Sep 6, 2024

Conversation

canstand
Copy link
Collaborator

No description provided.

@canstand
Copy link
Collaborator Author

Hi @mxschmitt , Playwright throws an error and exits on certificate mismatch. The difference with the playwright-python test is that the TLS server uses the go standard option tls.RequireAndVerifyClientCert.

Pls take a look at : https://github.com/playwright-community/playwright-go/actions/runs/10465991368/job/28982096640?pr=480#step:6:166

@mxschmitt
Copy link
Collaborator

Looks indeed like an upstream bug! Let me try to take a look tomorrow. Should be easily reproducible. Thanks for letting me know!

@mxschmitt mxschmitt mentioned this pull request Aug 22, 2024
Merged
@mxschmitt
Copy link
Collaborator

@canstand fyi microsoft/playwright#32258 - you might need to wait until this one lands or disable http2 in the tests for now.

@canstand
Copy link
Collaborator Author

@mxschmitt after disabling http2, the Windows tests have a similar error, but only on go 1.22 and lower.

@canstand canstand marked this pull request as ready for review August 23, 2024 08:20
@mxschmitt
Copy link
Collaborator

mxschmitt commented Aug 24, 2024 •
edited
Loading

Please try version 1.47.0-alpha-2024-08-24 which contains a few bug-fixes and seems to fix that specific issue. I wasn't able to reproduce it with that specific version anymore.

@canstand canstand changed the title chore: roll to Playwright v1.46.1 chore: roll to Playwright v1.47.0 Sep 6, 2024
@mxschmitt mxschmitt merged commit a1b6055 into playwright-community:main Sep 6, 2024
22 checks passed
@canstand canstand deleted the roll-v1.46 branch September 7, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxschmitt mxschmitt mxschmitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@canstand @mxschmitt