-
Notifications
You must be signed in to change notification settings - Fork 129
Language service crate #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this introduces a new top-level folder, could you also add it to the code owners file? Perhaps with you, Bill, and Ian as owners? |
bamarsha
reviewed
Jun 8, 2023
idavis
reviewed
Jun 9, 2023
bamarsha
reviewed
Jun 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes related to SourceMap
look good.
…om/microsoft/qsharp into minestarks/language-service-native
…tarks/language-service-native
idavis
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
language_service
Rust crate. The language service is simply a struct that maintains a compilation state for each known document. It receives document edits and updates the current compilation state based on those edits. It provides methods (get_completions
,get_definition
,hover
) to get information about the current compilation.Review note This PR is a subset of the draft PR at #364 . That PR is an end-to-end implementation with everything wired up and functional in the playground and VS Code. You may want to refer to #364 if you have questions about how some of the things defined in this PR will end up getting used.
Review note the actual editor feature implementations at
completion.rs
,definition.rs
andhover.rs
are meant to be placeholders with very limited functionality (see the unit tests for the very few cases we do support). Fleshing out the actual features will be done in later PRs.