forked from facebook/react-native
-
Notifications
You must be signed in to change notification settings - Fork 148
ci: properly pass NPM auth token secret to script #2434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannyvv
approved these changes
Mar 25, 2025
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Mar 25, 2025
## Summary: I noticed NPM publish failing still. My guess is the second addition of this line to our `.npmrc` is messing it up ## Test Plan: Testing on 0.78 release.
Saadnajmi
added a commit
that referenced
this pull request
Mar 26, 2025
## Summary: Backport of #2434 to 0.78-stable, along with a change file to publish a new version ## Test Plan: As with Publish pipeline changes, merge and hope for the best 🙏
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Mar 26, 2025
## Summary: I noticed NPM publish failing still. My guess is the second addition of this line to our `.npmrc` is messing it up ## Test Plan: Testing on 0.78 release.
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Mar 26, 2025
## Summary: I noticed NPM publish failing still. My guess is the second addition of this line to our `.npmrc` is messing it up ## Test Plan: Testing on 0.78 release.
This was referenced Mar 26, 2025
Saadnajmi
added a commit
that referenced
this pull request
Mar 26, 2025
## Summary: Backport #2422 , #2432 , and #2434 to 0.76-stable ## Test Plan: CI should pass --------- Co-authored-by: Tommy Nguyen <[email protected]>
Saadnajmi
added a commit
that referenced
this pull request
Mar 26, 2025
## Summary: Backport #2422 , #2432 , and #2434 to 0.77-stable ## Test Plan: CI should pass --------- Co-authored-by: Tommy Nguyen <[email protected]>
Saadnajmi
added a commit
that referenced
this pull request
Apr 8, 2025
Backport of #2434 to 0.78-stable, along with a change file to publish a new version As with Publish pipeline changes, merge and hope for the best 🙏
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I noticed NPM publish failing still. My guess is the second addition of this line to our
.npmrc
is messing it upTest Plan:
Testing on 0.78 release.