Skip to content

ci: properly pass NPM auth token secret to script #2434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 25, 2025

Conversation

Saadnajmi
Copy link
Collaborator

Summary:

I noticed NPM publish failing still. My guess is the second addition of this line to our .npmrc is messing it up

Test Plan:

Testing on 0.78 release.

@Saadnajmi Saadnajmi requested a review from a team as a code owner March 24, 2025 01:29
@Saadnajmi Saadnajmi changed the title ci: Don't add NPM auth token to npmrc twice ci: properly pass NPM auth token secret to script Mar 25, 2025
@Saadnajmi Saadnajmi merged commit 2bbf089 into microsoft:main Mar 25, 2025
12 checks passed
@Saadnajmi Saadnajmi deleted the extra-line branch March 25, 2025 22:20
Saadnajmi added a commit to Saadnajmi/react-native-macos that referenced this pull request Mar 25, 2025
## Summary:

I noticed NPM publish failing still. My guess is the second addition of
this line to our `.npmrc` is messing it up

## Test Plan:

Testing on 0.78 release.
Saadnajmi added a commit that referenced this pull request Mar 26, 2025
## Summary:

Backport of #2434 to 0.78-stable, along with a change file to publish a
new version

## Test Plan:

As with Publish pipeline changes, merge and hope for the best 🙏
Saadnajmi added a commit to Saadnajmi/react-native-macos that referenced this pull request Mar 26, 2025
## Summary:

I noticed NPM publish failing still. My guess is the second addition of
this line to our `.npmrc` is messing it up

## Test Plan:

Testing on 0.78 release.
Saadnajmi added a commit to Saadnajmi/react-native-macos that referenced this pull request Mar 26, 2025
## Summary:

I noticed NPM publish failing still. My guess is the second addition of
this line to our `.npmrc` is messing it up

## Test Plan:

Testing on 0.78 release.
Saadnajmi added a commit that referenced this pull request Mar 26, 2025
## Summary:

Backport #2422 , #2432 , and #2434 to 0.76-stable

## Test Plan:

CI should pass

---------

Co-authored-by: Tommy Nguyen <[email protected]>
Saadnajmi added a commit that referenced this pull request Mar 26, 2025
## Summary:

Backport #2422 , #2432 , and #2434 to 0.77-stable

## Test Plan:

CI should pass

---------

Co-authored-by: Tommy Nguyen <[email protected]>
Saadnajmi added a commit that referenced this pull request Apr 8, 2025
Backport of #2434 to 0.78-stable, along with a change file to publish a
new version

As with Publish pipeline changes, merge and hope for the best 🙏
@Saadnajmi Saadnajmi mentioned this pull request May 1, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants