Skip to content

ci(0.76): backport publish pipeline changes #2444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 26, 2025

Conversation

Saadnajmi
Copy link
Collaborator

Summary:

Backport #2422 , #2432 , and #2434 to 0.76-stable

Test Plan:

CI should pass

Saadnajmi and others added 3 commits March 25, 2025 18:00
`nx release` requires a `.npmrc` file. Let's create one with our NPM
auth token, and remove it after we finish publishing out of an abundance
of caution.

Change is already in 0.76-stable and 0.77-stable. For whatever reason,
it works on 0.76 and not on 0.77

---------

Co-authored-by: Tommy Nguyen <[email protected]>
## Summary:

`prerelease` can be `undefined` while `generatorOptions.preid` is an
empty string. Update the check to handle that

## Test Plan:

CI should pass
## Summary:

I noticed NPM publish failing still. My guess is the second addition of
this line to our `.npmrc` is messing it up

## Test Plan:

Testing on 0.78 release.
@Saadnajmi Saadnajmi requested a review from a team as a code owner March 26, 2025 01:02
@Saadnajmi Saadnajmi enabled auto-merge (squash) March 26, 2025 12:33
@Saadnajmi Saadnajmi merged commit 4294b8e into microsoft:0.76-stable Mar 26, 2025
10 checks passed
@Saadnajmi Saadnajmi deleted the 0.76/backport-ci-changes branch March 26, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants