Skip to content

feat: rebrand mitxonline open edx as MIT learn #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 30, 2025

Conversation

asadali145
Copy link
Contributor

@asadali145 asadali145 commented May 9, 2025

What are the relevant tickets?

first part of https://github.com/mitodl/hq/issues/7233 to update logo site wide

Description (What does it do?)

Updates the logos from MITx Online to MIT Learn and trademark logo to MIT logo

Screenshots (if appropriate):

Legacy Header Logo:
Screenshot 2025-05-15 at 12 51 14 PM

MFE Header Logo:
Screenshot 2025-05-15 at 12 51 34 PM

Legacy Footer Logo:
Screenshot 2025-05-15 at 12 52 35 PM

MFE Footer Logo:
Screenshot 2025-05-15 at 12 52 40 PM

Studio Header Logo:
Screenshot 2025-05-15 at 12 54 59 PM

How can this be tested?

  • Enable mitxonline theme locally
  • Add the below in private.py
ENABLE_COMPREHENSIVE_THEMING = True
COMPREHENSIVE_THEME_DIRS = ["/openedx/edx-platform/themes"]
DEFAULT_SITE_THEME='mitxonline-theme'
LOGO_URL_PNG_FOR_EMAIL = f"{LMS_BASE_URL}/static/mitxonline-theme/images/logo.svg"
LOGO_URL = f"{LMS_BASE_URL}/static/mitxonline-theme/images/logo.svg"
LOGO_TRADEMARK_URL = f"{LMS_BASE_URL}/static/mitxonline-theme/images/mit-logo.svg"
  • In learning MFE set the following in .env.development
LOGO_TRADEMARK_URL=http://local.openedx.io:8000/static/mitxonline-theme/images/mit-logo.svg
MIT_BASE_URL=https://mit.edu

NOTE: I am not sure about studio logo setting, I had to copy the studio-logo.png to edx-platform/cms/static/images/

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @asadali145, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request focuses on rebranding the MITx Online platform to MIT Learn. The primary change involves updating the logo across the application. This is part of a larger effort tracked in the issue https://github.com/mitodl/hq/issues/7233.

Highlights

  • Logo Update: The MITx Online logo (lms/static/images/logo.svg) has been replaced with the new MIT Learn logo.

Changelog

  • lms/static/images/logo.svg
    • Replaced the old MITx Online logo with the new MIT Learn logo.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


A logo's changed,
A new brand starts to gleam bright,
MIT Learn takes flight.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the logos from MITx Online to MIT Learn. The changes involve replacing the old logo SVG with a new one. Overall, the change seems straightforward and necessary for the rebranding effort.

Merge Readiness

The pull request appears to be a simple rebranding update, replacing the logo. Given the limited scope and the absence of any identified issues, the pull request seems ready for merging. However, I am unable to directly approve the pull request, and it should be reviewed and approved by others before merging.

@asadali145 asadali145 marked this pull request as ready for review May 15, 2025 08:05
@arslanashraf7 arslanashraf7 self-assigned this May 16, 2025
@asadali145 asadali145 merged commit 825faee into main May 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants