feat: update mitxonline edx logos to learn #3213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ardiea
approved these changes
May 15, 2025
|
How/can we control the deployment of this? I'd like to test it on QA first, of course, but I also need to take care about releasing it to production. Does it require an open edX deployment? |
|
@pdpinch This requires Open edX deployment. The best option to test it on QA and not release on Production is to control the production release. We should not trigger production release before we test this on QA. Discussed another option with @arslanashraf7 but we do not recommend because it is a bit complex to manage:
CC: @arslanashraf7 |
arslanashraf7
approved these changes
May 16, 2025
There was a problem hiding this comment.
Looks good if we are going with the simpler approach of not deploying on production until we test it #3213 (comment).
|
@pdpinch Should I go ahead and merge these PRs? |
feoh
pushed a commit
that referenced
this pull request
May 30, 2025
* feat: update mitxonline edx logos to learn * add MIT_BASE_URL setting for legacy footer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
First part of https://github.com/mitodl/hq/issues/7233 to update logos
Description (What does it do?)
Updates the MITx Online logo to MIT Learn and trademark logo to MIT logo.