Skip to content

[FIX] TypeError from 'v' of ANTs version string #3430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

0rC0
Copy link
Contributor

@0rC0 0rC0 commented Jan 14, 2022

Summary

Building ANTs from source code, actually the recommended procedure, leads to a version string with a leading v that causes the TypeError.

#Fixes #3427

List of changes proposed in this PR (pull-request)

[x] Strip the leading v in the ANTs version-string parsing function

Acknowledgment

  • [ X] (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

Building ANTs from source code, actually the recommended procedure, leads to a version string with a leading `v` that causes the `TypeError`.

This little fix may solve nipy#3427
@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #3430 (26e805b) into master (cd4c34d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3430   +/-   ##
=======================================
  Coverage   65.21%   65.21%           
=======================================
  Files         307      307           
  Lines       40478    40479    +1     
  Branches     5352     5352           
=======================================
+ Hits        26399    26400    +1     
+ Misses      13008    13004    -4     
- Partials     1071     1075    +4     
Flag Coverage Δ
unittests 64.94% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/interfaces/ants/base.py 74.00% <100.00%> (+0.53%) ⬆️
nipype/algorithms/icc.py 57.53% <0.00%> (ø)
nipype/interfaces/fsl/utils.py 63.76% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd4c34d...26e805b. Read the comment docs.

@effigies
Copy link
Member

effigies commented Apr 2, 2022

Thanks for this. I wanted to add some tests and ended up refactoring a bit. So this is incorporated in #3444.

@effigies effigies closed this Apr 2, 2022
@effigies effigies added this to the 1.7.1 milestone Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: '<' not supported between instances of 'str' and 'int'
2 participants