FIX: Use a more robust strategy for detecting ANTs version #3444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building ANTs from source code, actually the recommended procedure, leads to a version string with a leading `v` that causes the `TypeError`. This little fix may solve nipy#3427
Codecov Report
@@ Coverage Diff @@
## master #3444 +/- ##
=======================================
Coverage 65.21% 65.22%
=======================================
Files 308 308
Lines 40530 40533 +3
Branches 5353 5354 +1
=======================================
+ Hits 26433 26438 +5
+ Misses 13021 13020 -1
+ Partials 1076 1075 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3427.
Replaces #3430.