-
-
Notifications
You must be signed in to change notification settings - Fork 32k
src: support (de)serialization of DOMException
#57372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c73bc7f
to
b039fee
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57372 +/- ##
==========================================
- Coverage 90.22% 90.10% -0.12%
==========================================
Files 630 630
Lines 185259 185332 +73
Branches 36245 36247 +2
==========================================
- Hits 167143 166998 -145
- Misses 11063 11285 +222
+ Partials 7053 7049 -4
🚀 New features to boost your workflow:
|
0aec3cf
to
96f824c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Private symbols are per-isolate data and initialized before an Environment
is created (in IsolateData
). It does not depend on an Environment
. Yet, it needs a bit of refactor on the NewContext
and GetPerContextExports
so that InitializePrimordials
can access the private symbols.
947742c
to
ee1dacf
Compare
IIUC, we need to pass |
440dcd7
to
cded81b
Compare
@@ -52,6 +55,8 @@ class DOMException { | |||
constructor(message = '', options = 'Error') { | |||
ErrorCaptureStackTrace(this); | |||
|
|||
this[is_dom_exception] = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use class property syntax to set this using [[Define]]
semantics?
class DOMException {
[is_dom_exception] = true;
constructor(message = '', options = 'Error') {
...
}
}
cded81b
to
2ec57d7
Compare
Opened #57479 to help tackle this. That one, as the first step, works fine, but I need a bit of time working on this, as with current manual (de)serialize approach there is a
|
2ec57d7
to
ed31a8c
Compare
Added serialization and deserialization support for
DOMException
. Ideally we shouldn't do this in native, but since it's compiled before an Environment exists, we cannot mark it askCloneable
and provide associated serialization methods in JS land.Fixes: #49181