Skip to content

lib,src: support DOMException ser-des #58649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2025
Merged

lib,src: support DOMException ser-des #58649

merged 1 commit into from
Jun 11, 2025

Conversation

legendecas
Copy link
Member

Added serialization and deserialization support for DOMException. An alternative to #57372 that utilizes the JSTransferable mechanism.

Co-Authored-By: jazelly [email protected]
Fixes: #49181

@legendecas @jazelly
lib,src: support DOMException ser-des
ab82850 
Added serialization and deserialization support for `DOMException`.

Co-Authored-By: jazelly <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. worker Issues and PRs related to Worker support. labels Jun 9, 2025
@legendecas legendecas requested a review from jazelly June 9, 2025 16:26
@codecov Codecov
Copy link

codecov bot commented Jun 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.18750% with 5 lines in your changes missing coverage. Please review.

Project coverage is 90.16%. Comparing base (b23648e) to head (ab82850).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
src/api/environment.cc 77.27% 2 Missing and 3 partials ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #58649   +/-   ##
=======================================
  Coverage   90.15%   90.16%           
=======================================
  Files         636      637    +1     
  Lines      187891   187943   +52     
  Branches    36879    36884    +5     
=======================================
+ Hits       169386   169450   +64     
+ Misses      11272    11244   -28     
- Partials     7233     7249   +16
Files with missing lines Coverage Δ
lib/internal/per_context/domexception.js 80.85% <100.00%> (+5.03%) ⬆️
lib/internal/worker/clone_dom_exception.js 100.00% <100.00%> (ø)
src/node_builtins.cc 79.32% <100.00%> (+0.04%) ⬆️
src/api/environment.cc 77.00% <77.27%> (+0.29%) ⬆️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 9, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 9, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67368/

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 9, 2025
jazelly
jazelly approved these changes Jun 9, 2025
View reviewed changes
Copy link
Member

@jazelly jazelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks for the PR.

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 11, 2025
@nodejs-github-bot nodejs-github-bot merged commit 5457443 into nodejs:main Jun 11, 2025
77 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 5457443

@legendecas legendecas deleted the dom-exception-transfer branch June 11, 2025 16:12
targos pushed a commit that referenced this pull request Jun 16, 2025
@legendecas @jazelly @targos
lib,src: support DOMException ser-des
6390f70 
Added serialization and deserialization support for `DOMException`.

Co-Authored-By: jazelly <[email protected]>
PR-URL: #58649
Fixes: #49181
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
@github-actions github-actions bot mentioned this pull request Jun 16, 2025
Closed
This was referenced Jun 23, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

@jazelly jazelly jazelly approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stucturedClone defective for DataCloneError
6 participants
@legendecas @nodejs-github-bot @jasnell @addaleax @Ethan-Arrowood @jazelly